From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id D3BA0385AC09 for ; Tue, 26 Sep 2023 09:41:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D3BA0385AC09 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 037ED1F74C; Tue, 26 Sep 2023 09:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1695721308; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=127HQSfAG0u0p5CvkEdifJKlKqv470XcQmKKgMFVX7s=; b=0h0Au0MZl/nS7q0q6YUUuNDTITU2euyRmwXkI2p5XoGtifVOXjhORlglvSY+5KcAkxq2+T zQIVAlW0pmf/+ADTAzmRqpQcb5wwPsqCcnceqPKuuq7+CBOial6lo2dX4XQp6zj8GPh2ry W+gbP7c9yOvpa6m/gH5LbMODLtBWkGY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1695721308; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=127HQSfAG0u0p5CvkEdifJKlKqv470XcQmKKgMFVX7s=; b=SVcG3L69wRCIQfRHCKOUe7PRlO2PwJzfE6bDZ5UDIN3WTC/3/3q1db3+Wv0CfSfEAnoSeh ltPpSjIdQsEhriDA== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id D6D1B2C142; Tue, 26 Sep 2023 09:41:47 +0000 (UTC) Date: Tue, 26 Sep 2023 09:41:47 +0000 (UTC) From: Richard Biener To: Juzhe-Zhong cc: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Subject: Re: [PATCH] MATCH: Optimize COND_ADD reduction pattern In-Reply-To: <20230926082548.944794-1-juzhe.zhong@rivai.ai> Message-ID: References: <20230926082548.944794-1-juzhe.zhong@rivai.ai> User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 26 Sep 2023, Juzhe-Zhong wrote: > Current COND_ADD reduction pattern can't optimize floating-point vector. > As Richard suggested: https://gcc.gnu.org/pipermail/gcc-patches/2023-September/631336.html > Allow COND_ADD reduction pattern to optimize floating-point vector. > > Bootstrap and Regression is running. > > Ok for trunk if tests pass ? I just wondered about fixed point - zerop seems to also allow fixed_zerop. Maybe do if (ANY_INTEGRAL_TYPE_P (type) || (FLOAT_TYPE_P (type) && fold_real_zero_addition_p (type, NULL_TREE, @4, 0))) (also for the other patch) to avoid touching the fixed point case. Richard. > gcc/ChangeLog: > > * match.pd: Optimize COND_ADD reduction pattern. > > --- > gcc/match.pd | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/gcc/match.pd b/gcc/match.pd > index 5061c19e086..398beaebd27 100644 > --- a/gcc/match.pd > +++ b/gcc/match.pd > @@ -8863,8 +8863,10 @@ and, > > c = mask1 && mask2 ? d + b : d. */ > (simplify > - (IFN_COND_ADD @0 @1 (vec_cond @2 @3 integer_zerop) @1) > - (IFN_COND_ADD (bit_and @0 @2) @1 @3 @1)) > + (IFN_COND_ADD @0 @1 (vec_cond @2 @3 zerop@4) @1) > + (if (ANY_INTEGRAL_TYPE_P (type) > + || fold_real_zero_addition_p (type, NULL_TREE, @4, 0)) > + (IFN_COND_ADD (bit_and @0 @2) @1 @3 @1))) > > /* Detect simplication for a conditional length reduction where > > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)