* [PATCH] ifcvt: Fix comments
@ 2023-09-27 6:51 Juzhe-Zhong
2023-09-27 7:18 ` Richard Biener
0 siblings, 1 reply; 3+ messages in thread
From: Juzhe-Zhong @ 2023-09-27 6:51 UTC (permalink / raw)
To: gcc-patches; +Cc: richard.sandiford, rguenther, jeffreyalaw, Juzhe-Zhong
Fix comments since original comment is confusing.
gcc/ChangeLog:
* tree-if-conv.cc (is_cond_scalar_reduction): Fix comments.
---
gcc/tree-if-conv.cc | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gcc/tree-if-conv.cc b/gcc/tree-if-conv.cc
index 799f071965e..a8c915913ae 100644
--- a/gcc/tree-if-conv.cc
+++ b/gcc/tree-if-conv.cc
@@ -1747,11 +1747,11 @@ is_cond_scalar_reduction (gimple *phi, gimple **reduc, tree arg_0, tree arg_1,
and convert to
- reduc_2 = PHI <0, reduc_3>
- tmp1 = (unsigned type)reduce_1;
+ reduc_2 = PHI <0, reduc_1>
+ tmp1 = (unsigned type)reduc_1;
ifcvt = cond_expr ? rhs2 : 0
tmp2 = tmp1 +/- ifcvt;
- reduce_1 = (signed type)tmp2; */
+ reduc_1 = (signed type)tmp2; */
if (CONVERT_EXPR_CODE_P (reduction_op))
{
--
2.36.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ifcvt: Fix comments
2023-09-27 6:51 [PATCH] ifcvt: Fix comments Juzhe-Zhong
@ 2023-09-27 7:18 ` Richard Biener
2023-09-27 7:25 ` Li, Pan2
0 siblings, 1 reply; 3+ messages in thread
From: Richard Biener @ 2023-09-27 7:18 UTC (permalink / raw)
To: Juzhe-Zhong; +Cc: gcc-patches, richard.sandiford, jeffreyalaw
On Wed, 27 Sep 2023, Juzhe-Zhong wrote:
> Fix comments since original comment is confusing.
OK
> gcc/ChangeLog:
>
> * tree-if-conv.cc (is_cond_scalar_reduction): Fix comments.
>
> ---
> gcc/tree-if-conv.cc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/tree-if-conv.cc b/gcc/tree-if-conv.cc
> index 799f071965e..a8c915913ae 100644
> --- a/gcc/tree-if-conv.cc
> +++ b/gcc/tree-if-conv.cc
> @@ -1747,11 +1747,11 @@ is_cond_scalar_reduction (gimple *phi, gimple **reduc, tree arg_0, tree arg_1,
>
> and convert to
>
> - reduc_2 = PHI <0, reduc_3>
> - tmp1 = (unsigned type)reduce_1;
> + reduc_2 = PHI <0, reduc_1>
> + tmp1 = (unsigned type)reduc_1;
> ifcvt = cond_expr ? rhs2 : 0
> tmp2 = tmp1 +/- ifcvt;
> - reduce_1 = (signed type)tmp2; */
> + reduc_1 = (signed type)tmp2; */
>
> if (CONVERT_EXPR_CODE_P (reduction_op))
> {
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH,
Frankenstrasse 146, 90461 Nuernberg, Germany;
GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] ifcvt: Fix comments
2023-09-27 7:18 ` Richard Biener
@ 2023-09-27 7:25 ` Li, Pan2
0 siblings, 0 replies; 3+ messages in thread
From: Li, Pan2 @ 2023-09-27 7:25 UTC (permalink / raw)
To: Richard Biener, Juzhe-Zhong; +Cc: gcc-patches, richard.sandiford, jeffreyalaw
Committed, thanks Richard.
Pan
-----Original Message-----
From: Richard Biener <rguenther@suse.de>
Sent: Wednesday, September 27, 2023 3:18 PM
To: Juzhe-Zhong <juzhe.zhong@rivai.ai>
Cc: gcc-patches@gcc.gnu.org; richard.sandiford@arm.com; jeffreyalaw@gmail.com
Subject: Re: [PATCH] ifcvt: Fix comments
On Wed, 27 Sep 2023, Juzhe-Zhong wrote:
> Fix comments since original comment is confusing.
OK
> gcc/ChangeLog:
>
> * tree-if-conv.cc (is_cond_scalar_reduction): Fix comments.
>
> ---
> gcc/tree-if-conv.cc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/tree-if-conv.cc b/gcc/tree-if-conv.cc
> index 799f071965e..a8c915913ae 100644
> --- a/gcc/tree-if-conv.cc
> +++ b/gcc/tree-if-conv.cc
> @@ -1747,11 +1747,11 @@ is_cond_scalar_reduction (gimple *phi, gimple **reduc, tree arg_0, tree arg_1,
>
> and convert to
>
> - reduc_2 = PHI <0, reduc_3>
> - tmp1 = (unsigned type)reduce_1;
> + reduc_2 = PHI <0, reduc_1>
> + tmp1 = (unsigned type)reduc_1;
> ifcvt = cond_expr ? rhs2 : 0
> tmp2 = tmp1 +/- ifcvt;
> - reduce_1 = (signed type)tmp2; */
> + reduc_1 = (signed type)tmp2; */
>
> if (CONVERT_EXPR_CODE_P (reduction_op))
> {
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH,
Frankenstrasse 146, 90461 Nuernberg, Germany;
GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-27 7:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-27 6:51 [PATCH] ifcvt: Fix comments Juzhe-Zhong
2023-09-27 7:18 ` Richard Biener
2023-09-27 7:25 ` Li, Pan2
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).