From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 252373858D28 for ; Mon, 9 Oct 2023 07:31:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 252373858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 5F5FD1F381; Mon, 9 Oct 2023 07:31:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1696836702; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zix1aeMnSgI7xzeqqp/uR/3NJkwSJnddRQ6z8QtTpxw=; b=0k9oo3eUNxmC6dpnTP80XdWelyW4E4gA3jyeBVSgWiZxYW+IlTyutxDGF9FYGrODKneqK6 V9m7PHmm4gZKZwp6zu0fBQUHj72MxOL84UYNiHoLEdEbMEekJB4gBGNeCEiuxFVbxsvq/I fx46DJDPypsdEcGQeyBlvMUl5CClaAE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1696836702; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zix1aeMnSgI7xzeqqp/uR/3NJkwSJnddRQ6z8QtTpxw=; b=QaD5pcn7UX/VyYcLiO+6Jc7/Bjx7AtLEjglfGhRox2cEoUlzRvT76Nilz5rkXp27q1OVoA HFQcWvvNCrtCJTCQ== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 2D1812C142; Mon, 9 Oct 2023 07:31:42 +0000 (UTC) Date: Mon, 9 Oct 2023 07:31:42 +0000 (UTC) From: Richard Biener To: Jeff Law cc: Juzhe-Zhong , gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Subject: Re: [PATCH] TEST: Fix dump FAIL of vect-multitypes-16.c for RVV In-Reply-To: Message-ID: References: <20231008113531.3905091-1-juzhe.zhong@rivai.ai> User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 8 Oct 2023, Jeff Law wrote: > > > On 10/8/23 05:35, Juzhe-Zhong wrote: > > RVV (RISC-V Vector) doesn't enable vect_unpack, but we still vectorize this > > case well. > > So, adjust dump check for RVV. > > > > gcc/testsuite/ChangeLog: > > > > * gcc.dg/vect/vect-multitypes-16.c: Fix dump FAIL of RVV. > I'd hoped to avoid a bunch of risc-v special casing in the generic part of the > testsuite. Basically the more we have target specific conditionals rather > than conditionals using properties, the more likely we are to keep revisiting > this stuff over time and possibly for other architectures as well. > > What is it about risc-v's vector support that allows it to optimize this case? > Is it the same property that allows us to handle the outer loop vectorization > tests that you changed in another patch? I suspect for VLA vectorization we can use direct conversion from char to long long here? I also notice the testcase uses 'char', not specifying its sign. So either of [sz]extVxyzDIVxyzQI is possibly provided by RISCV? (or possibly via some intermediate types in a multi-step conversion) For non-VLA and with the single vector size restriction we'd need unpacking. So it might be better { target { vect_unpack || { vect_vla && vect_sext_char_longlong } } } where I think neither vect_vla nor vect_sext_char_longlong exists. Richard - didn't you run into similar things with SVE? Richard. > Neither an ACK nor NAK right now. > > Jeff > > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)