From: Richard Biener <rguenther@suse.de>
To: Tamar Christina <tamar.christina@arm.com>
Cc: gcc-patches@gcc.gnu.org, nd@arm.com, jlaw@ventanamicro.com
Subject: Re: [PATCH v3 1/2]middle-end: expand copysign handling from lockstep to nested iters
Date: Mon, 6 Nov 2023 13:02:20 +0000 (UTC) [thread overview]
Message-ID: <nycvar.YFH.7.77.849.2311061302140.8772@jbgna.fhfr.qr> (raw)
In-Reply-To: <patch-17982-tamar@arm.com>
On Mon, 6 Nov 2023, Tamar Christina wrote:
> Hi All,
>
> various optimizations in match.pd only happened on COPYSIGN in lock step
> which means they exclude IFN_COPYSIGN. COPYSIGN however is restricted to only
> the C99 builtins and so doesn't work for vectors.
>
> The patch expands these optimizations to work as nested iters.
>
> This is needed for the second patch which will add the testcase.
>
> Bootstrapped Regtested on aarch64-none-linux-gnu and no issues.
>
> Ok for master?
OK.
> Thanks,
> Tamar
>
> gcc/ChangeLog:
>
> PR tree-optimization/109154
> * match.pd: expand existing copysign optimizations.
>
> --- inline copy of patch --
> diff --git a/gcc/match.pd b/gcc/match.pd
> index 7d651a6582d169793cca4f9a70e334dd80014d92..db95931df0672cf4ef08cca36085c3aa6831519e 100644
> --- a/gcc/match.pd
> +++ b/gcc/match.pd
> @@ -1074,37 +1074,37 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)
>
> /* cos(copysign(x, y)) -> cos(x). Similarly for cosh. */
> (for coss (COS COSH)
> - copysigns (COPYSIGN)
> - (simplify
> - (coss (copysigns @0 @1))
> - (coss @0)))
> + (for copysigns (COPYSIGN)
> + (simplify
> + (coss (copysigns @0 @1))
> + (coss @0))))
>
> /* pow(copysign(x, y), z) -> pow(x, z) if z is an even integer. */
> (for pows (POW)
> - copysigns (COPYSIGN)
> - (simplify
> - (pows (copysigns @0 @2) REAL_CST@1)
> - (with { HOST_WIDE_INT n; }
> - (if (real_isinteger (&TREE_REAL_CST (@1), &n) && (n & 1) == 0)
> - (pows @0 @1)))))
> + (for copysigns (COPYSIGN)
> + (simplify
> + (pows (copysigns @0 @2) REAL_CST@1)
> + (with { HOST_WIDE_INT n; }
> + (if (real_isinteger (&TREE_REAL_CST (@1), &n) && (n & 1) == 0)
> + (pows @0 @1))))))
> /* Likewise for powi. */
> (for pows (POWI)
> - copysigns (COPYSIGN)
> - (simplify
> - (pows (copysigns @0 @2) INTEGER_CST@1)
> - (if ((wi::to_wide (@1) & 1) == 0)
> - (pows @0 @1))))
> + (for copysigns (COPYSIGN)
> + (simplify
> + (pows (copysigns @0 @2) INTEGER_CST@1)
> + (if ((wi::to_wide (@1) & 1) == 0)
> + (pows @0 @1)))))
>
> (for hypots (HYPOT)
> - copysigns (COPYSIGN)
> - /* hypot(copysign(x, y), z) -> hypot(x, z). */
> - (simplify
> - (hypots (copysigns @0 @1) @2)
> - (hypots @0 @2))
> - /* hypot(x, copysign(y, z)) -> hypot(x, y). */
> - (simplify
> - (hypots @0 (copysigns @1 @2))
> - (hypots @0 @1)))
> + (for copysigns (COPYSIGN)
> + /* hypot(copysign(x, y), z) -> hypot(x, z). */
> + (simplify
> + (hypots (copysigns @0 @1) @2)
> + (hypots @0 @2))
> + /* hypot(x, copysign(y, z)) -> hypot(x, y). */
> + (simplify
> + (hypots @0 (copysigns @1 @2))
> + (hypots @0 @1))))
>
> /* copysign(x, CST) -> [-]abs (x). */
> (for copysigns (COPYSIGN_ALL)
>
>
>
>
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH,
Frankenstrasse 146, 90461 Nuernberg, Germany;
GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)
prev parent reply other threads:[~2023-11-06 13:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 10:20 Tamar Christina
2023-11-06 10:20 ` [PATCH v3 2/2]middle-end match.pd: optimize fneg (fabs (x)) to copysign (x, -1) [PR109154] Tamar Christina
2023-11-06 13:04 ` Richard Biener
2023-11-07 9:25 ` Tamar Christina
2023-11-07 9:29 ` Richard Biener
2023-11-10 12:24 ` Prathamesh Kulkarni
2023-11-10 12:44 ` Tamar Christina
2023-11-10 13:12 ` Richard Biener
2023-11-10 21:22 ` Andrew Pinski
2023-11-13 7:08 ` Richard Biener
2023-11-13 7:13 ` Tamar Christina
2023-11-06 13:02 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.77.849.2311061302140.8772@jbgna.fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jlaw@ventanamicro.com \
--cc=nd@arm.com \
--cc=tamar.christina@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).