From: Richard Biener <rguenther@suse.de>
To: Joel Hutton <Joel.Hutton@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Richard Sandiford <Richard.Sandiford@arm.com>
Subject: Re: [vect-patterns] Refactor widen_plus/widen_minus as internal_fns
Date: Fri, 12 Nov 2021 11:48:18 +0100 (CET) [thread overview]
Message-ID: <o18549n0-6n81-o1s-6736-o6s4r2s696or@fhfr.qr> (raw)
In-Reply-To: <DB9PR08MB66033352579A386D6CC9F0CAF5949@DB9PR08MB6603.eurprd08.prod.outlook.com>
On Thu, 11 Nov 2021, Joel Hutton wrote:
> Hi all,
>
> This refactor allows widening vect patterns (such as widen_plus/widen_minus) to be represented as
> either internal_fns or tree_codes and replaces the current widen_plus/widen_minus with internal_fn versions. This refactor is split into 3 patches.
>
> Boostrapped and regression tested on aarch64.
>
> Ok for stage 3?
IIRC Richard had comments the last round so I'd appreciate if he'd chime
in as well.
0001 looks OK to me.
diff --git a/gcc/internal-fn.c b/gcc/internal-fn.c
index e8fd16b9c21..4ab80d24b89 100644
--- a/gcc/internal-fn.c
+++ b/gcc/internal-fn.c
@@ -52,6 +52,7 @@ along with GCC; see the file COPYING3. If not see
#include "explow.h"
#include "rtl-iter.h"
#include "gimple-range.h"
+#include <map>
please use #define INCLUDE_MAP before the system.h include instead.
Is it really necessary to build a new std::map for each optab lookup?!
That looks quite ugly and inefficient. We'd usually - if necessary
at all - build a auto_vec<std::pair<key,data> > and .sort ()
and .bsearch () it.
I'm not sure I understand DEF_INTERNAL_OPTAB_MULTI_FN, neither this
cover letter nor the patch ChangeLog explains anything.
0003 looks OK to me.
So that leaves 0002 which I don't understand as said above.
Richard.
next prev parent reply other threads:[~2021-11-12 10:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 15:13 Joel Hutton
2021-11-12 10:48 ` Richard Biener [this message]
2021-11-12 11:42 ` Joel Hutton
2021-11-16 10:19 ` Joel Hutton
2021-12-02 18:10 ` Richard Sandiford
2022-04-13 15:52 ` Joel Hutton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=o18549n0-6n81-o1s-6736-o6s4r2s696or@fhfr.qr \
--to=rguenther@suse.de \
--cc=Joel.Hutton@arm.com \
--cc=Richard.Sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).