public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Yujie Yang <yangyujie@loongson.cn>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Yang Yujie <yangyujie@loongson.cn>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v2 1/4] LoongArch: improved target configuration interface
Date: Thu, 31 Aug 2023 15:36:21 +0800	[thread overview]
Message-ID: <oqapcqhugd3idwi7mdsly2fd7xdp2f2x77yimddfwgikg4lphs@kkiox2uew22n> (raw)
In-Reply-To: <gii7jhwwnaevmqyemcghjyb4lntag66d2map4kwlnycwv7ozse@6pku5rxj6vyd>

On Thu, Aug 31, 2023 at 11:14:13AM +0800, Yujie Yang wrote:
> On Wed, Aug 30, 2023 at 09:36:22PM +0000, Joseph Myers wrote:
> > On Wed, 30 Aug 2023, Yang Yujie wrote:
> > 
> > > +A suffix @code{[/ARCH][/OPTION]...]} may follow immediately after the ABI
> > > +identifier to customize the compiler options for building the given set of
> > > +libraries.  @code{ARCH} denotes the architecture name recognized by the
> > > +@code{-march=ARCH} compiler option, which acts as a basic target ISA
> > > +configuration that can be adjusted using the subsequent @code{OPTION}
> > > +suffixes, where each @code{OPTION} is a compiler option itself.
> > 
> > Since ARCH and OPTION are not literal strings of program source code, you 
> > should actually be using @var{arch} and @var{option} for them (and @dots{} 
> > instead of ..., since the ... isn't literal source code either).
> > 
> > This patch series also adds a new configure option --with-strict-align-lib 
> > that needs documenting in the corresponding patch.
> > 
> > -- 
> > Joseph S. Myers
> > joseph@codesourcery.com
> 
> Thanks for the review.  Does the following fix look good?
> If so, I will include these in the patchset.

Found something else to fix, I will post them in the next version
of the patchset.


  reply	other threads:[~2023-08-31  7:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30  1:58 [PATCH 0/4] LoongArch: target configuration interface update Yang Yujie
2023-08-30  1:58 ` [PATCH v2 1/4] LoongArch: improved target configuration interface Yang Yujie
2023-08-30 21:36   ` Joseph Myers
2023-08-31  3:14     ` Yujie Yang
2023-08-31  7:36       ` Yujie Yang [this message]
2023-08-31 17:56       ` Joseph Myers
2023-09-01  1:19         ` Yujie Yang
2023-08-30  1:58 ` [PATCH v2 2/4] LoongArch: define preprocessing macros "__loongarch_{arch,tune}" Yang Yujie
2023-08-30  1:58 ` [PATCH v2 3/4] LoongArch: add new configure option --with-strict-align-lib Yang Yujie
2023-08-30  5:25   ` Xi Ruoyao
2023-08-30  6:51     ` Yujie Yang
2023-08-30  8:22       ` Xi Ruoyao
2023-08-30 10:01         ` Yujie Yang
2023-08-30  1:58 ` [PATCH v2 4/4] LoongArch: support loongarch*-elf target Yang Yujie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=oqapcqhugd3idwi7mdsly2fd7xdp2f2x77yimddfwgikg4lphs@kkiox2uew22n \
    --to=yangyujie@loongson.cn \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).