From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 8652F3858D20 for ; Thu, 7 Dec 2023 17:52:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8652F3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8652F3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701971555; cv=none; b=tr/QaWPs7Jv5KtlM1yaTKoNoONBM4XmEZcNpqdSoS99Bxnwi/obKfhcl+/Vohp9GZIRNWp4Re7dF2/WMcLvmATjhhUONorlphBxuSH7U/ts7n4H2egZJSCNh+uPTCIPuZpdB75o5hlT1lTJDsoB/tKzW4xx+LisZJ1wIEgEcp3Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701971555; c=relaxed/simple; bh=uGdPOTNKeDAifyHLcTdPzfffta5quxUhRN+IUMUcZOw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=TGXcUEL3kuPb2d3dp5qBrbcj+qLfsXHfwirGzMUwYikjxrUb4CCI672zuvq7+LHuaasbb6ypjXHGp118KpxGjbUk0b1FQp3ggqSONxSoMXzq89qOzfRj7qKE74SSTZP/JcxPC0H7g/8xEk3uRGFwxdCik3dH3XvVwPF//un99FQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1d053c45897so10423755ad.2 for ; Thu, 07 Dec 2023 09:52:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1701971552; x=1702576352; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:organization:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=uYHDxsS9H1JiikC+2oPbpk6D1uVRpPW1ZV6Skn2+fmE=; b=LrFX8eyM1jPPfWaQd5gAyhiSI1RYbcwgWHRsGQnfvmHBY2gB0gfFfvlcu6jznutLkb FYXe5HJQkfc/ITAgNYhQikw8Or8YxhEWky2oyQWfA39D8bVe8BCXW4/4VeQSsff2u8pG piEW+LiXHHobec/Mx6R1vFafyw6q4mPK/KKxAmmehQrGlGRDOaJandigFHlC29JGFRFe J471TWowHVPxJOUmBuXGoPqxFBwlFKollk5LWFja8BqQoldp+hcsZZVuuma/LPkhN0vF JfUaVX4KTQ02HKBpjPqREU99gjd3InjL7Iww9hRdT/XHUuNZ8f0mTOV792usezxyvpsw SbIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701971552; x=1702576352; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:organization:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uYHDxsS9H1JiikC+2oPbpk6D1uVRpPW1ZV6Skn2+fmE=; b=DGBOVQ3+Fr4gL6oR3Ibf0hFbjCAstmAmKjFU93ca6jlBoTqu46U1vgyyRScjuy1pZ+ OShJQN7HzZyR1IEVL6ydx4hHnTTBLvHNWGcHHUf+AVwKXzjIwpjDPwykr8+NX03+6fRv S11NFqzuH4d5q3MZBxailbuu+smMPB8kvdoTFV2hdpYdtiecG8Cq4qMSC59jXPrz+nSW VOqT9WnrDK8QTWaP3aGPQMLg2/UCeUv0068M+9zCH915IZvGaSkFMuQ9GPU/uqyLulR6 og+EGUYLXqlRaA9d/Orthm5dhRdmahXZZSspjaXRcByo8xWuXI3tn2UFGh44xTKCxxFS mX3w== X-Gm-Message-State: AOJu0YxptF/+1okq3Ni+jUwgyBIbx6+f/leIaS58Tcsias3rXRjt69yX ZLWx335iYjPQvbsqXOgjy1+HkA== X-Google-Smtp-Source: AGHT+IFZfWnI8dZ/wOWDnGS97URBGH8i3sI063fd4Y90Uh+ORV65Gu7HkqLrjQUn27/Xx3PBhAYVog== X-Received: by 2002:a17:902:e851:b0:1d0:6ffd:9e04 with SMTP id t17-20020a170902e85100b001d06ffd9e04mr3159408plg.86.1701971552302; Thu, 07 Dec 2023 09:52:32 -0800 (PST) Received: from free.home ([2804:7f1:2080:b1a3:1419:837f:795e:787a]) by smtp.gmail.com with ESMTPSA id e13-20020a170902d38d00b001b7cbc5871csm95128pld.53.2023.12.07.09.52.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 09:52:31 -0800 (PST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 3B7HqJDu280841 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 7 Dec 2023 14:52:20 -0300 From: Alexandre Oliva To: Thomas Schwinge , FX Coudert Cc: Tobias Burnus , Richard Biener , , Jeremy Bennett , Craig Blackmore , Graham Markall , Martin Jambor , "Jan Hubicka" , Jim Wilson , Jeff Law , Jakub Jelinek , Tom de Vries Subject: [PATCH] Organization: Free thinker, does not speak for AdaCore References: <87lea7sh0h.fsf@euler.schwinge.homeip.net> <8734wet11e.fsf@euler.schwinge.homeip.net> Date: Thu, 07 Dec 2023 14:52:19 -0300 In-Reply-To: <8734wet11e.fsf@euler.schwinge.homeip.net> (Thomas Schwinge's message of "Thu, 7 Dec 2023 17:44:45 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_PORT,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Dec 7, 2023, Thomas Schwinge wrote: > Thank you for looking into this so promptly! You're welcome ;-) > during IPA pass: emutls > [...]/source-gcc/gcc/testsuite/c-c++-common/strub-unsupported-3.c:18:= 1: internal compiler error: in verify_curr_properties, at passes.cc:2198 Aah, this smells a lot like the issue that Fran=C3=A7ois-Xavier reported, that the following patch is expected to fix. I'm still regstrapping it on x86_64-linux-gnu, after checking that it addressed the symptom on a cross compiler to the target for which it had originally been reported. Ok to install, once you confirm that it cures these ICEs? strub: skip emutls after strubm errors The emutls pass requires PROP_ssa, but if the strubm pass (or any other pre-SSA pass) issues errors, all of the build_ssa_passes are skipped, so the property is not set, but emutls still attempts to run, on targets that use it, despite earlier errors, so it hits the unsatisfied requirement. Adjust emutls to be skipped in case of earlier errors. for gcc/ChangeLog * tree-emutls.cc: Include diagnostic-core.h. (pass_ipa_lower_emutls::gate): Skip if errors were seen. --- gcc/tree-emutls.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/tree-emutls.cc b/gcc/tree-emutls.cc index 5dca5a8291356..38de202717a1a 100644 --- a/gcc/tree-emutls.cc +++ b/gcc/tree-emutls.cc @@ -35,6 +35,7 @@ along with GCC; see the file COPYING3. If not see #include "langhooks.h" #include "tree-iterator.h" #include "gimplify.h" +#include "diagnostic-core.h" /* for seen_error */ =20 /* Whenever a target does not support thread-local storage (TLS) natively, we can emulate it with some run-time support in libgcc. This will in @@ -841,7 +842,7 @@ public: bool gate (function *) final override { /* If the target supports TLS natively, we need do nothing here. */ - return !targetm.have_tls; + return !targetm.have_tls && !seen_error (); } =20 unsigned int execute (function *) final override --=20 Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive