From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by sourceware.org (Postfix) with ESMTPS id 576903858004 for ; Tue, 7 Nov 2023 10:04:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 576903858004 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 576903858004 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::730 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699351479; cv=none; b=L1w5MY0CbC77gkS7nOleoY59XFk3ZY0lWc2Z2HfxVyZUI5AKnI+GXBrYr/c1sKvUS1CcdWL7APOs4XPH91C19G/EEFhV2Jrq4AzISwXgs7mPcl0f3nT6rHjrtpVXLp8MAuw4CwMa3hnyWIlGYNbUp538rzwHbAFS1UUNpzAmRKQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699351479; c=relaxed/simple; bh=TpEb7E0NvrOdD3t5i0NhELpY6wzQjKKqp7jQBhYBqAM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=jxJI/SgOmNqGXq4wWVob0sfa2RA2MdIVOKSC3WYoIttclEKebPLce87tEOaheXxKrgeCSfuLpJOJuNGFWGwIQkEVCDx4pl1KPcmpkpy6NwTadF4GairabMjkF94FVTpL3XAtn8L3NdyiMrC4xMQ+1YpMbgmvsSFsVsnSPQMEUQs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qk1-x730.google.com with SMTP id af79cd13be357-77a277eb084so362387185a.2 for ; Tue, 07 Nov 2023 02:04:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1699351477; x=1699956277; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=CY32hDBJ39Cc5SGbsxkJYBfIcewP6zXqTP77FtdeIpQ=; b=PpB+iJY1BJCBVGLblJDoHApw7p1ylH/f/e/6rkT7YLT/1KEvJkt3anR6e6qE8rRmJ0 Cg1IHBO3xLMvBxXnsYI8NuxnmmokXQXsjRXXVRumxzxSQiNDByisZ5HHhxk4vdwo1ryJ akf2hRDTBRPlJ4Rtv+Kmx3xBSu50ZVYO+s2U3YDys0BdOm6IdKSiMxGGlmkCVQq5AyTE WModhOLzGEepd2mjhRdvMco50fAeeD9NH5TYk22pGIRdCktUZD/ImcqQ0iCQdhOr+/IM 3JlK/pgRvm+Bl8qdDadsRLOrh6P2fkPcf7Lylktm5X9bknDbYz6iKb5P8lPN3pE3EdF/ ZOoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699351477; x=1699956277; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CY32hDBJ39Cc5SGbsxkJYBfIcewP6zXqTP77FtdeIpQ=; b=Odd1rUHBIATZ144RuYg6B+D5jh4Lxu2t5EsVE3lDyerCV+/iJDxTqZ3XcEL4FX5UGV T9QUvkbZixjqfkCZgc9FGxOiKGf/nQeLhZxEr09is7WC81Cq41sx8JIp4FD2I1RuLhOa CdDm9C4QyesK2niAxTeMYQ5kEW5gK5PpZlbJQ8ImV7Fs94xqsd8EHaEqE2RDEWdAd45v S5Q5ORwHwRmMTurObXn1DOWzWbiVzYtX2P9dl5517uSv4vmfLTVykONko431QDDjQWC6 xLlxlhUR7+3WDax1p80YHKqaob7AZi/buosD9+Ch8kSJW+mP8wbgI1JbgPGt6mV226UA pxAQ== X-Gm-Message-State: AOJu0YzZJFvNCij4c3PGFLcc5I4my2tDnFuk11/iTynuEngyXPMrZuBe Z/93U12kmTIuKV/82X5zlRusQw== X-Google-Smtp-Source: AGHT+IGxzMBE61z5Vd+PhZQNU/sfPKCm2uRgPn5fSECn/0OMKejxctGameizQq5rWZgunZGBPu/E9A== X-Received: by 2002:a05:620a:394f:b0:772:6364:1409 with SMTP id qs15-20020a05620a394f00b0077263641409mr37301841qkn.10.1699351477724; Tue, 07 Nov 2023 02:04:37 -0800 (PST) Received: from free.home ([2804:7f1:2080:e9c8:ff5e:88e8:a900:d7b4]) by smtp.gmail.com with ESMTPSA id m16-20020ae9e710000000b0076e1e2d6496sm4051409qka.104.2023.11.07.02.04.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Nov 2023 02:04:37 -0800 (PST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 3A7A4KBx2155218 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 7 Nov 2023 07:04:21 -0300 From: Alexandre Oliva To: Mike Stump Cc: gcc-patches@gcc.gnu.org, Rainer Orth , libstdc++@gcc.gnu.org Subject: Re: testsuite: introduce hostedlib effective target Organization: Free thinker, does not speak for AdaCore References: <600FDF8F-67C5-408F-BD24-9A3964A8BFA1@comcast.net> Date: Tue, 07 Nov 2023 07:04:20 -0300 In-Reply-To: <600FDF8F-67C5-408F-BD24-9A3964A8BFA1@comcast.net> (Mike Stump's message of "Sun, 5 Nov 2023 12:40:59 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: [adding libstdc++@] On Nov 5, 2023, Mike Stump wrote: > Ick. Indeed ;-) > I wish there were fewer changed lines and not 1 per test > case. It feels like we've painted ourselves into a corner. The libstdc++ testsuite took a different approach, detecting missing headers (and libraries?) at error pruning time, and xfailing the tests, which seems to be more in line with what you are looking for. That approach, though more expedient, seems more fragile to me, in that an actual bug that caused headers to go missing would cause tests to be silently skipped rather than fail. I expect the set of headers, and thus of affected tests, won't by very dynamic, so it's kind of a one-shot change. Of course new tests might be added that rely on such headers, and would likely go unnoticed until someone tries them on a non-hosted libstdc++. We could alleviate this if libstdc++ headers that are not installed on hosted systems issued a warning (conditional on some macro defined by the testsuite, say -D_GLIBCXX_WARN_HOSTED_ONLY). For tests aimed exclusively at hosted libstdc++, we'd then use a dg directive that both implied this requirement, and changed the macro definition to suppress the warning. Then anyone who added a testcase that included hosted headers without indicating its hostedlib requirement would get a fail even when testing with a hosted libstdc++. -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive