From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11366 invoked by alias); 21 Nov 2009 05:06:21 -0000 Received: (qmail 11195 invoked by uid 22791); 21 Nov 2009 05:06:20 -0000 X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,SUBJECT_FUZZY_VPILL X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 21 Nov 2009 05:05:25 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAL55NiK024144 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 21 Nov 2009 00:05:23 -0500 Received: from freie.oliva.athome.lsd.ic.unicamp.br (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nAL55L4F018251 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 21 Nov 2009 00:05:23 -0500 Received: from livre.localdomain (livre.oliva.athome.lsd.ic.unicamp.br [172.31.160.2]) by freie.oliva.athome.lsd.ic.unicamp.br (8.14.3/8.14.3) with ESMTP id nAL55LWe028876; Sat, 21 Nov 2009 03:05:21 -0200 Received: from livre.localdomain (aoliva@localhost [127.0.0.1]) by livre.localdomain (8.14.3/8.14.3/Debian-5) with ESMTP id nAL55KnU009168; Sat, 21 Nov 2009 03:05:20 -0200 Received: (from aoliva@localhost) by livre.localdomain (8.14.3/8.14.3/Submit) id nAL55KU0009166; Sat, 21 Nov 2009 03:05:20 -0200 From: Alexandre Oliva To: Richard Guenther Cc: gcc-patches@gcc.gnu.org Subject: Re: [vta, graphite?] propagate degenerate phi nodes into debug stmts References: <84fc9c000911080156iff6d687o26db10af3e9fba5d@mail.gmail.com> <84fc9c000911170739v76a2e911vc6794e597c8d134e@mail.gmail.com> <84fc9c000911190253v19390bd2le683c769bf0ab4d@mail.gmail.com> <84fc9c000911200239u240b9a0v80107db183851a92@mail.gmail.com> Date: Sat, 21 Nov 2009 05:22:00 -0000 In-Reply-To: <84fc9c000911200239u240b9a0v80107db183851a92@mail.gmail.com> (Richard Guenther's message of "Fri, 20 Nov 2009 11:39:45 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-11/txt/msg01141.txt.bz2 --=-=-= Content-length: 155 On Nov 20, 2009, Richard Guenther wrote: > No, the tree-ssa-pre.c change is fine anyways. Ok, here's what I'm checking in. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=ssa-pre-no-release-after-remove-phi-node.patch Content-length: 688 for gcc/ChangeLog from Alexandre Oliva * tree-ssa-pre.c (remove_dead_inserted_code): Don't release_defs after remove_phi_node. Index: gcc/tree-ssa-pre.c =================================================================== --- gcc/tree-ssa-pre.c.orig 2009-11-19 01:14:18.000000000 -0200 +++ gcc/tree-ssa-pre.c 2009-11-19 01:14:52.000000000 -0200 @@ -4462,8 +4462,10 @@ remove_dead_inserted_code (void) if (gimple_code (t) == GIMPLE_PHI) remove_phi_node (&gsi, true); else - gsi_remove (&gsi, true); - release_defs (t); + { + gsi_remove (&gsi, true); + release_defs (t); + } } } VEC_free (gimple, heap, worklist); --=-=-= Content-length: 257 -- Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist Red Hat Brazil Compiler Engineer --=-=-=--