From: Alexandre Oliva <aoliva@redhat.com>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PR debug/41343] introduce debug expr temps
Date: Wed, 07 Oct 2009 08:35:00 -0000 [thread overview]
Message-ID: <or3a5voda5.fsf@livre.localdomain> (raw)
In-Reply-To: <84fc9c000910060303i6dc4750ay68e38008f1b36cc5@mail.gmail.com> (Richard Guenther's message of "Tue, 6 Oct 2009 12:03:00 +0200")
On Oct 6, 2009, Richard Guenther <richard.guenther@gmail.com> wrote:
>> Anyhow, if we find it not to be true, it shouldn't be too hard to get
>> debug temps into SSA operands, especially if we're to add vops to debug
>> bind stmts as well.
> Gah. Over my dead body!
:-)
> Fair enough. Mind adding a comment here? Mind adding
> a DEBUG_DECL_UID macro that encapsulates the negation?
Will do.
>> But the bind point is that where the stmt was before, and the moved DEF
>> might very well be referenced at a point between the bind point and the
>> reinsertion point.
> Please get some numbers here - I think this will for example
> artificially add debug stmts on basic block removal.
We remove basic blocks “backwards” too, from last to first stmt, and
dominated before dominator. So, since the newly-added code only adds a
debug stmt if it finds the removed SSA DEF is USEd in a debug stmt, it
would only add a deug stmt if we were to remove a dominator without
removing its dominated, i.e., if we were to remove an SSA DEF without
removing its corresponding USEs. We don't do that, do we?
--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist Red Hat Brazil Compiler Engineer
next prev parent reply other threads:[~2009-10-07 7:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 19:51 Alexandre Oliva
2009-09-23 8:42 ` Richard Guenther
2009-09-23 11:54 ` Richard Guenther
2009-09-23 12:02 ` Richard Guenther
2009-09-30 8:24 ` Alexandre Oliva
2009-09-30 9:54 ` Richard Guenther
2009-10-02 6:06 ` Alexandre Oliva
2009-10-02 7:10 ` Alexandre Oliva
2009-10-03 15:02 ` Richard Guenther
2009-10-06 6:43 ` Alexandre Oliva
2009-10-06 10:30 ` Richard Guenther
2009-10-07 8:35 ` Alexandre Oliva [this message]
2009-10-07 10:24 ` Richard Guenther
2009-10-08 19:48 ` Alexandre Oliva
2009-10-09 7:48 ` Alexandre Oliva
2009-10-09 11:29 ` Richard Guenther
2009-10-11 13:05 ` Alexandre Oliva
2009-10-11 14:26 ` Richard Guenther
2009-10-12 6:36 ` Alexandre Oliva
2009-10-12 8:58 ` Richard Guenther
2009-10-12 19:01 ` Alexandre Oliva
2009-10-13 6:02 ` Eric Botcazou
2009-10-13 6:41 ` Jakub Jelinek
2009-10-13 9:38 ` Richard Guenther
2009-10-13 21:01 ` Alexandre Oliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=or3a5voda5.fsf@livre.localdomain \
--to=aoliva@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).