From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTPS id 75E553858D33 for ; Wed, 22 Feb 2023 12:38:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 75E553858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 29C081160F2; Wed, 22 Feb 2023 07:38:48 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id G5Bnu8tzQ+HM; Wed, 22 Feb 2023 07:38:48 -0500 (EST) Received: from free.home (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id B7B421160F1; Wed, 22 Feb 2023 07:38:47 -0500 (EST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 31MCcNb7289545 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 22 Feb 2023 09:38:25 -0300 From: Alexandre Oliva To: Christophe Lyon Cc: gcc-patches@gcc.gnu.org, nickc@redhat.com, richard.earnshaw@arm.com Subject: Re: [PATCH] [arm] adjust tests for quotes around +cdecp Organization: Free thinker, does not speak for AdaCore References: <34f5c89d-9298-2ed2-95b5-faee25da0b72@arm.com> Errors-To: aoliva@lxoliva.fsfla.org Date: Wed, 22 Feb 2023 09:38:23 -0300 In-Reply-To: <34f5c89d-9298-2ed2-95b5-faee25da0b72@arm.com> (Christophe Lyon's message of "Mon, 20 Feb 2023 14:15:15 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, Christophe, On Feb 20, 2023, Christophe Lyon wrote: > On 2/17/23 08:17, Alexandre Oliva via Gcc-patches wrote: >> >> Back when quotes were added around "+cdecp" in the "coproc must be >> a constant immediate" error in arm-builtins.cc, tests for that message >> lagged behind. Fixed thusly. >> >> Regstrapped on x86_64-linux-gnu. >> Tested on arm-vxworks7 (gcc-12) and arm-eabi (trunk). Ok to install? > It seems this changed with r12-6553-gc3782843badbf3, right? Yup. > I see this commit added quotes in several others places: are the two > tests you fix the only ones impacted? https://gcc.gnu.org/pipermail/gcc-patches/2023-February/612176.html in asm-flag-4.c also fixed fallout from that patch, I realize now, but that was all that came up in our testing. I didn't start from that patch, I was just going through test results, investigating the failures and fixing them or at least annotating the failures as expected. It is conceivable that other quoted strings appear in tests that are skipped by all of the target variants that we test. Indeed, I went through some arm-*-eabi variants not long ago, and these didn't come up. So, in case you're wondering whether to look for the other strings in the tests or somesuch, please don't assume I've already done so. -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Disinformation flourishes because many people care deeply about injustice but very few check the facts. Ask me about