From: Alexandre Oliva <oliva@adacore.com>
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>, Jeff Law <law@redhat.com>,
gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: introduce overridable clear_cache emitter
Date: Thu, 10 Dec 2020 07:58:26 -0300 [thread overview]
Message-ID: <or4kku53n1.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <orwnxzdlsl.fsf@lxoliva.fsfla.org> (Alexandre Oliva's message of "Thu, 03 Dec 2020 11:08:42 -0300")
On Dec 3, 2020, Alexandre Oliva <oliva@adacore.com> wrote:
> + local_define_builtin ("__builtin___clear_cache", ftype,
> + BUILT_IN_CLEAR_CACHE,
> + "__builtin___clear_cache",
> + ECF_NOTHROW);
Ugh, so that somehow worked for aarch64-linux-gnu-gfortran, but the
aarch64-elf Ada compiler started issuing calls to an undefined
__builtin___clear_cache symbol.
The second string actual passed to local_define_builtin binds to formal
libname, which explains at least the new problem. I've so far
restrained my curiosity as to why it wasn't a problem on
aarch64-linux-gnu-gfortran. I'm checking it in as obvious, so far
lightly tested on x86_64-linux-gnu and -x-aarch64-elf.
drop __builtin_ from __clear_cache libname
From: Alexandre Oliva <oliva@adacore.com>
I made a cut&pasto in my previous patch for tree.c, causing platforms
that have CLEAR_INSN_CACHE defined, and none of the internal
__clear_cache expansion overriders, to issue calls to symbols named
__builtin___clear_cache rather than __clear_cache, on languages other
than those in the C family. Oops.
This patch removes __builtin_ from the string used as the libname for
__buuiltin___clear_cache.
for gcc/ChangeLog
* tree.c (build_common_builtin_nodes): Drop __builtin_ from
__clear_cache libname.
---
gcc/tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/tree.c b/gcc/tree.c
index 72311005f57b2..4eb365205e3bd 100644
--- a/gcc/tree.c
+++ b/gcc/tree.c
@@ -10736,7 +10736,7 @@ build_common_builtin_nodes (void)
if (!builtin_decl_explicit_p (BUILT_IN_CLEAR_CACHE))
local_define_builtin ("__builtin___clear_cache", ftype,
BUILT_IN_CLEAR_CACHE,
- "__builtin___clear_cache",
+ "__clear_cache",
ECF_NOTHROW);
local_define_builtin ("__builtin_nonlocal_goto", ftype,
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Vim, Vi, Voltei pro Emacs -- GNUlius Caesar
next prev parent reply other threads:[~2020-12-10 10:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 2:35 Alexandre Oliva
2020-11-16 18:20 ` Olivier Hainque
2020-12-02 18:23 ` Jeff Law
2020-12-03 10:38 ` Christophe Lyon
2020-12-03 10:59 ` Alexandre Oliva
2020-12-03 14:08 ` Alexandre Oliva
2020-12-03 16:46 ` Jeff Law
2020-12-05 10:19 ` Andreas Schwab
2020-12-05 21:01 ` Alexandre Oliva
2020-12-05 21:19 ` Jakub Jelinek
2020-12-10 8:47 ` Alexandre Oliva
2020-12-10 10:58 ` Alexandre Oliva [this message]
2020-12-13 16:53 ` Jeff Law
2020-12-03 12:28 ` Andreas Schwab
2020-12-03 12:43 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=or4kku53n1.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).