From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52788 invoked by alias); 30 Oct 2019 09:41:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 52767 invoked by uid 89); 30 Oct 2019 09:41:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Oct 2019 09:40:59 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7023E5615A; Wed, 30 Oct 2019 05:40:58 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id LfA6braRHyCd; Wed, 30 Oct 2019 05:40:58 -0400 (EDT) Received: from free.home (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id C5D7056159; Wed, 30 Oct 2019 05:40:57 -0400 (EDT) Received: from livre.home (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id x9U9ejsf120756 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Oct 2019 06:40:47 -0300 From: Alexandre Oliva To: Joseph Myers Cc: , , Subject: Re: introduce -fcallgraph-info option References: Date: Wed, 30 Oct 2019 09:43:00 -0000 In-Reply-To: (Joseph Myers's message of "Mon, 28 Oct 2019 23:25:01 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-10/txt/msg02098.txt.bz2 On Oct 28, 2019, Joseph Myers wrote: > We have a test in the testsuite that all option help text consistently=20 > ends with '.' (see gcc.misc-tests/help.exp). I'd have expected these=20 > options, lacking that '.', to cause that test to fail. Here's the patch. Tested on x86_64-linux-gnu. Ok to install? Test --help=3Dcommon for full sentences The portion of help.exp that checks that help output contains full sentences failed to cover common options. for gcc/testsuite/ChangeLog * gcc.misc-tests/help.exp: Test --help=3Dcommon for full sentences. --- gcc/testsuite/gcc.misc-tests/help.exp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gcc/testsuite/gcc.misc-tests/help.exp b/gcc/testsuite/gcc.misc= -tests/help.exp index b8a09fc..4bb359f 100644 --- a/gcc/testsuite/gcc.misc-tests/help.exp +++ b/gcc/testsuite/gcc.misc-tests/help.exp @@ -146,8 +146,7 @@ check_for_options c "--help=3Djoined,undocumented" "" "= " "" # find the source a failure. =20 foreach cls { "ada" "c" "c++" "d" "fortran" "go" \ - "optimizers" "param" "target" "warnings" } { - + "common" "optimizers" "param" "target" "warnings" } { check_for_options c "--help=3D$cls" "" "^ +-.*\[^:.\]$" "" } =20 --=20 Alexandre Oliva, freedom fighter he/him https://FSFLA.org/blogs/lxo Be the change, be Free! FSF VP & FSF Latin America board member GNU Toolchain Engineer Free Software Evangelist Hay que enGNUrecerse, pero sin perder la terGNUra jam=C3=A1s - Che GNUevara