public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Alexandre Oliva <aoliva@redhat.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: Jakub Jelinek <jakub@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [patch] Fix var-tracking with dynamic stack realignment on x86
Date: Mon, 30 May 2011 10:07:00 -0000	[thread overview]
Message-ID: <or4o4c4o8i.fsf@livre.localdomain> (raw)
In-Reply-To: <201105291057.34348.ebotcazou@adacore.com> (Eric Botcazou's	message of "Sun, 29 May 2011 10:57:34 +0200")

On May 29, 2011, Eric Botcazou <ebotcazou@adacore.com> wrote:

> 	* var-tracking.c (vt_add_function_parameter): Remap incoming MEMs with
>       crtl-> args.internal_arg_pointer based address to arg_pointer_rtx if
> 	there is a DRAP register.
> 	(vt_init_cfa_base): Don't equate cfa_base_rtx if stack was realigned.
> 	(vt_initialize): Initialize cfa_base_rtx if there is a DRAP register.

This makes sense to me.  I don't think I can approve it, but if I could,
I would ;-)

-- 
Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/   FSF Latin America board member
Free Software Evangelist      Red Hat Brazil Compiler Engineer

  parent reply	other threads:[~2011-05-30  7:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-22 23:15 Eric Botcazou
2011-05-23 10:07 ` Jakub Jelinek
2011-05-23 10:25   ` Eric Botcazou
2011-05-23 12:04     ` Jakub Jelinek
2011-05-23 18:17     ` Jakub Jelinek
2011-05-24 12:21       ` Eric Botcazou
2011-05-24 12:26         ` Jakub Jelinek
2011-05-24 14:20           ` Eric Botcazou
2011-05-24 14:59             ` Jakub Jelinek
2011-05-24 23:44               ` Eric Botcazou
2011-05-29 16:14       ` Eric Botcazou
2011-05-30  9:55         ` Jakub Jelinek
2011-05-30 13:10           ` Eric Botcazou
2011-05-30 13:31             ` Jakub Jelinek
2011-05-30 17:10               ` Eric Botcazou
2011-05-30 10:07         ` Alexandre Oliva [this message]
2011-05-30 11:21           ` Bernd Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=or4o4c4o8i.fsf@livre.localdomain \
    --to=aoliva@redhat.com \
    --cc=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).