From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 347 invoked by alias); 16 Jan 2013 13:17:56 -0000 Received: (qmail 334 invoked by uid 22791); 16 Jan 2013 13:17:53 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Jan 2013 13:17:46 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0GDHksB018285 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 16 Jan 2013 08:17:46 -0500 Received: from freie.oliva.athome.lsd.ic.unicamp.br (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0GDHg5K019919 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 16 Jan 2013 08:17:43 -0500 Received: from livre.localdomain (livre-to-gw.oliva.athome.lsd.ic.unicamp.br [172.31.160.19]) by freie.oliva.athome.lsd.ic.unicamp.br (8.14.5/8.14.5) with ESMTP id r0GDHdZE028236; Wed, 16 Jan 2013 11:17:39 -0200 Received: from livre.localdomain (aoliva@localhost.localdomain [127.0.0.1]) by livre.localdomain (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id r0GDHcpm009640; Wed, 16 Jan 2013 11:17:38 -0200 Received: (from aoliva@localhost) by livre.localdomain (8.14.3/8.14.3/Submit) id r0GDHbul009639; Wed, 16 Jan 2013 11:17:37 -0200 From: Alexandre Oliva To: Jan Hubicka Cc: Richard Biener , gcc-patches@gcc.gnu.org Subject: Re: [PR libmudflap/53359] don't register symbols not emitted References: <20130116102428.GD5949@kam.mff.cuni.cz> Date: Wed, 16 Jan 2013 13:17:00 -0000 In-Reply-To: <20130116102428.GD5949@kam.mff.cuni.cz> (Jan Hubicka's message of "Wed, 16 Jan 2013 11:24:28 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00841.txt.bz2 On Jan 16, 2013, Jan Hubicka wrote: > 2) has the obvious advantage that unused vars are not going to be output just > for sake of checking code. For 2) the symtab_get_node test seems resonable to > me. That's what I first implemented, and I still firmly believe symtab_get_node is the correct test. TREE_ASM_WRITTEN doesn't carry the same information as far as external objects are concerned, so we ended up failing to register them when I tried it, and that caused regressions in the testsuite, with tests that were designed to catch precisely this sort of error. -- Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist Red Hat Brazil Compiler Engineer