From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id 951F23849ACB for ; Fri, 19 Apr 2024 12:45:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 951F23849ACB Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 951F23849ACB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713530762; cv=none; b=T6bv7KUf9yRXshR4+RlhVF+5+wFT/75vTIDYAVjfLmaPI8Li5e0KvHKiI3iYHi2Imb9lk2VfiE9xZphLmf1e+xo9ydg2IRZ/C0koI+ZZRl4TuuwL+VkojGTMJ7VRy5IOulSEQWsfFSbi/zLbMfuB9m5kzQGKehNzZo2aAfNLOyE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713530762; c=relaxed/simple; bh=wSg04wKQHJ4uQyZSlO1rWTlh8+JHkOXgfDX8vYJ/Rus=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=EXYQVqfrTu8erBatBALSPdpZLoazYrvlp2pvkdv1ktzwgh49mM9P5KlMWC5VfFeM1OQEv0x+PojfD3ybGNYTK1ds/GP9OkvMGZmqrcsOK7zXha6zLxu0hyt3dOaXK9SjXOYNSXvMFnemlceK8yK770fjwuXsUaSgssNieC2xF5I= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-5cf2d73a183so2154743a12.1 for ; Fri, 19 Apr 2024 05:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1713530758; x=1714135558; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=givqn7MsJM/cWXhcjOFsF9wd5dFHSWxWVxvASsnqaOE=; b=V5EJXpc7w3tt5HbfjHqO1bxXUA+rEAORTtef9//Jub0fi61SBJ4RYLY3XnjqHihMnL uqlRSgqRiSrfxDHr53uSrNyABUhAL7jjjMlvr+jrLRrG1ymoY7cyx4h0SXrZD5DchiZg mps2ytXicpNQQHpDIFJcl8iNqfrSzlWs2GK6+0jZG4/cED3Q/x8rAX2d0hTyPeRA0MMR 8IYiF440DqEEE3R+tkL2/CN2DYCSICvANfMXiNRwLmiRhcu8usaJi+169wvN8eSHsBsE wQWl6MzfeSs4s1mPZAcSUI19gPomQvyBq/FzwPf7R+TSWrT2DUgSB5VqlY0IyZoWLvk4 R0uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713530758; x=1714135558; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=givqn7MsJM/cWXhcjOFsF9wd5dFHSWxWVxvASsnqaOE=; b=mY2wfN80H57SfkEhDJXr62zkgX9srmXzsLvRVeW3VuoamKSRoFDLAtIWwi5OBm72tL IAirX2SEocsvocqHQNwcyw9eD4k5sM1QBLk7jmAv3jVLSN2bYmH6KTWD1hns86wEwD3H PBnYSZSQo/XEBIpto8DQ0vshWBulaKVq0Emy/O3WZqiqeS9q2TaZ3E2GHIZHPnqt9i4v xHNlSpVhqLKy8h0HLVZLL5IpArBzfLM6QM70uqZb6PGDQJXpbZs5tQr0GAKkjx8Xo62n fy1JPoY+xR6jbPwiGu5gcV8IGke8+Gh1Rjdm1dPPRm7j9TiABe3L1lzYb7Ju2r0a2IVM ZOpw== X-Gm-Message-State: AOJu0YxC+BWOnZjsqmL9bOu536NLdxw3wMK7axMBFCWO5K5iPkA6ePuh B64EJWsHOtvOpounkfd1lS4bDy7URd6y44vPUXRHVylTvJfbXMlKLglbkMa+lA== X-Google-Smtp-Source: AGHT+IE6fRSj049YXc58LiiaelpcCGoxjkoY/Yx2ibvlo1Myp6haZUneJGQPiXMLUrqGs+9lwYe4kg== X-Received: by 2002:a17:90b:182:b0:2a5:3f30:f5f6 with SMTP id t2-20020a17090b018200b002a53f30f5f6mr2917028pjs.20.1713530757749; Fri, 19 Apr 2024 05:45:57 -0700 (PDT) Received: from free.home ([2804:7f1:218b:5e2:c43b:e0c4:71a:241b]) by smtp.gmail.com with ESMTPSA id e5-20020a17090a4a0500b002a269828bb8sm3037695pjh.40.2024.04.19.05.45.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 05:45:57 -0700 (PDT) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 43JCj8Gp2542314 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 19 Apr 2024 09:45:09 -0300 From: Alexandre Oliva To: "Richard Earnshaw (lists)" Cc: gcc-patches@gcc.gnu.org, Rainer Orth , Mike Stump , Nick Clifton , Ramana Radhakrishnan Subject: Re: [PATCH] [testsuite] [arm] require arm_v8_1m_main for pacbti tests Organization: Free thinker, does not speak for AdaCore References: <13aceb3c-47b3-44f6-9ba0-2f8cfcd0d9ef@arm.com> Date: Fri, 19 Apr 2024 09:45:08 -0300 In-Reply-To: <13aceb3c-47b3-44f6-9ba0-2f8cfcd0d9ef@arm.com> (Richard Earnshaw's message of "Tue, 16 Apr 2024 09:56:25 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Apr 16, 2024, "Richard Earnshaw (lists)" wrote: > The require-effective-target flags test whether a specific set of > flags will make the compilation work, so they need to be used in > conjunction with the corresponding dg-add-options flags that then > apply those options. *nod*, that's the theory. Problem is the architectures suported by [add_options_for_]arm_arch_*[_ok] do not match exactly those expected by the tests, and I can't quite tell whether the subtle changes they would introduce would change what they intend to test, or even whether the differences are irrelevant, or would be sensible to add as variants to the dg machinery. I think it would take someone more familiar than I am with all of the ARM variants to do this correctly. I don't even know how these changes would need to be tested to be sure they remain correct. Would you be willing to take it from here, or would you accept the patch as an incremental yet imperfect improvement, or would you prefer to guide me in making it correct, and in verifying it (there are questions below)? I don't have a lot of cycles to put into this (we've already worked around the testsuite bugs we ran into), but it would be desirable to get a fix into GCC as well, if we can converge on one without unreasonably burdening anyone. v8_1m_main "-march=armv8.1-m.main+fp -mthumb" __ARM_ARCH_8M_MAIN__ v8_1m_main_pacbti "-march=armv8.1-m.main+pacbti+fp -mthumb" "__ARM_ARCH_8M_MAIN__ && __ARM_FEATURE_BTI && __ARM_FEATURE_PAUTH Why do these have +fp in -march but not in the v8_1m* arch name? gcc/testsuite/g++.target/arm/pac-1.C: /* { dg-options "-march=armv8.1-m.main+mve+pacbti -mbranch-protection=pac-ret -mthumb -mfloat-abi=hard -g -O0" } */ v8_1m_main_pacbti plus +mve minus +fp. Do we need a dg arch for that? gcc/testsuite/gcc.target/arm/acle/pacbti-m-predef-7.c: /* { dg-additional-options "-march=armv8.1-m.main+pacbti+fp --save-temps -mfloat-abi=hard" } */ gcc/testsuite/gcc.target/arm/acle/pacbti-m-predef-11.c: /* { dg-options "-march=armv8.1-m.main+fp+pacbti" } */ v8_1m_main_pacbti minus -mthumb. AFAICT the -mthumb is redundant. gcc/testsuite/gcc.target/arm/acle/pacbti-m-predef-12.c: /* { dg-options "-march=armv8-m.main+fp -mfloat-abi=softfp" } */ v8_1m_main minus -mthumb. AFAICT the -mthumb is redundant. gcc/testsuite/gcc.target/arm/bti-1.c: /* { dg-options "-march=armv8.1-m.main -mthumb -mfloat-abi=softfp -mbranch-protection=bti --save-temps" } */ gcc/testsuite/gcc.target/arm/bti-2.c: /* { dg-options "-march=armv8.1-m.main -mthumb -mfloat-abi=softfp -mbranch-protection=bti --save-temps" } */ v8_1m_main minus +fp. Can these be bumped to +fp, or do we need an extra dg arch? Are these missing +pacbti? Thanks, -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive