From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92]) by sourceware.org (Postfix) with ESMTPS id 3FC8C3857C6F; Wed, 22 Jun 2022 21:16:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3FC8C3857C6F Received: from linux-libre.fsfla.org ([209.51.188.54]:36010 helo=free.home) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o47gQ-0008M8-NQ; Wed, 22 Jun 2022 17:14:43 -0400 Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 25MLEJVH740225 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Jun 2022 18:14:20 -0300 From: Alexandre Oliva To: Eric Gallager Cc: gcc-patches , Paolo Bonzini , neroden@gcc.gnu.org, Ralf.Wildenhues@gmx.de Subject: Re: [PATCH] gcc/configure.ac: fix --enable-fixed-point enablement [PR34422] Organization: Free thinker, not speaking for the GNU Project References: Errors-To: aoliva@lxoliva.fsfla.org Date: Wed, 22 Jun 2022 18:14:19 -0300 In-Reply-To: (Eric Gallager's message of "Tue, 21 Jun 2022 14:07:52 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2022 21:16:56 -0000 Hello, Eric, On Jun 21, 2022, Eric Gallager wrote: > https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596654.html > (cc-ing the build machinery maintainers listed in MAINTAINERS this time) Thanks > On Tue, Jun 14, 2022 at 3:51 PM Eric Gallager wrote: >> So, in investigating PR target/34422, I discovered that the gcc >> subdirectory's configure script had an instance of AC_ARG_ENABLE with >> 3rd and 4th its arguments reversed: the one where it warns that the >> --enable-fixed-point flag is being ignored is the one where that flag >> hasn't even been passed in the first place. I'm not sure it was reversed or meant to enable the feature by default (if not given), but neither theory holds much water to me. Alas, the proposed change needs a little more work. Specifically, I don't think we should warn that the feature is not available if it was explicitly --disable'd. Moreover, if it was intended for fixed-point to be enabled by default, then the help string should probably mention the --disable flag instead, otherwise, the per-target setting to yes should probably be dropped. I dislike the duplication of the targets in two case statements. I think the best way to deal with this would be to only set enable_fixed_point=default in ACTION-IF-NOT-GIVEN, leaving ACTION-IF-GIVEN empty, and afterwards, if "x$enable_fixed_point" != "xno", check for target support, bumping default to yes on supported targets, and decaying it to no if unsupported, with a warning only if it was yes. >> with an appropriate ChangeLog? It's good practice to post the proposed ChangeLog entry along with the patch, so that it can also be reviewed. Thanks, -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Disinformation flourishes because many people care deeply about injustice but very few check the facts. Ask me about