From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 9022B3858D32 for ; Thu, 30 Nov 2023 07:21:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9022B3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9022B3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::629 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701328918; cv=none; b=kUrmbTAglpugoQVNFGOYacqJeYivbjdNhMC4HS4WLtUSR5AReMKK7Nq9Sj5JC2UyIRajkcskISTKjvsMGYSDz2PGe9W4+nXr5IQedo/t/riHXeYAHWiQH9RJ+oGOwMZsA6RNhFNj7taWAtzBeLXPCw1tEDLx3Fl1uNGAuhpP2S0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701328918; c=relaxed/simple; bh=HgaYguspGwAKgZAoUBAjJ/u7j+xWk4qiiD0cg6pvAXQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=YeeM5aRT7i8O0qVjuZ5baDyevtb27Q6cuyVtFRdGksUOp1P/GHHtYvVnLDiunpW4NumnPCiCObWDm8ELn1C6grnLoogICWyAsd9nw/y1xb63ZR1MQEwLPULs8rx8PE9xq2aeVNjQtxatVKUQTlGGvtW1zm99C1QlQXvPupo7d34= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1cfc35090b0so6038025ad.1 for ; Wed, 29 Nov 2023 23:21:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1701328915; x=1701933715; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:organization:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=nGjxDGJEqTyMdiO5PR2yfxB+TdMgqeVw6EarhN65Gvk=; b=HCZ3HzC0yF2B/3Xzs5WcijrQiRZC9oP5rQf37oGDNmLw1/SYqNZDsnSL+Pz7ln3tFd Ox2E9z569oYNX34sdNRHkU6ZoUmuPK9jEoZctAgdK3exMYto53Xbw/+75jbDBWL8Yh0p et5b9SohVlvgBbi24i99J6NNBdHXEGpvV+y3uOH+4Avq1d5HFIFuWR7+vBP3ZlrbUEJH nJDvhK/M86HbhxHHVgLwd/m1wH72Jp36xbfP57gQd5SMDKQMekUtrWKoq8r0Lsv7FQcK CRfGiZbul3pbi/X7cutXEIyKsOwCeSe6sxtbajXd3yFZZgGQCynu++F9uHY5eg5G+UOx fk8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701328915; x=1701933715; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:organization:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nGjxDGJEqTyMdiO5PR2yfxB+TdMgqeVw6EarhN65Gvk=; b=cUF6qyQGtmCuaibk2tDaynSDBSfWbt8Vux9zkjdJWOlOCoMQxa/EXJRFNiqWWXUirR bINrQ/1gLIiRQdaRDXZ0cvEptK51cRkI9MQk1TLiU4PiXcBxhJNMPrmwjVQxjsTrfERS aOuwqhoDnkN9zpBkk7qriw8ZPzsNPsRLXHhu/RdNyKZ5+p+T7pr8GqPBnOwIO3OaSWU+ m4l0PAahBM6n8naS+B0+C3jwAgusUzzs98BPXyQb4xTU5n68WQSJ+8B9Mk13Pv72/GcY AmlD9bbFfvbSirZ2C/Fqs46IzV1Dmx1WWkzbpZuqxS+EUhnQI4xH7ZeDqGsv/HzeGPQt qXpQ== X-Gm-Message-State: AOJu0YzPy4MxK0WT0Ym+yA/kfeyBiubKGGCR3dx0YnIQm+3fpiflj2f1 ovzPgZDTmdjNMQzAl6HhpdSRyg== X-Google-Smtp-Source: AGHT+IGugrnRkFf88G5XB3q8FOdsruJxQxgsXFgXHCy52+5x4UK8k0Xg1rceSXtsfO9DcalcDeigxA== X-Received: by 2002:a17:902:868d:b0:1cf:be44:bb9d with SMTP id g13-20020a170902868d00b001cfbe44bb9dmr12221830plo.30.1701328915503; Wed, 29 Nov 2023 23:21:55 -0800 (PST) Received: from free.home ([2804:7f1:2080:8d38:553a:9121:2785:9c36]) by smtp.gmail.com with ESMTPSA id bf8-20020a170902b90800b001cfd077fab4sm581170plb.282.2023.11.29.23.21.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 23:21:55 -0800 (PST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 3AU7LePb052320 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 30 Nov 2023 04:21:40 -0300 From: Alexandre Oliva To: Jason Merrill Cc: gcc-patches@gcc.gnu.org, David Malcolm , Rainer Orth , Mike Stump , Nathan Sidwell , "H.J. Lu" Subject: Re: [PATCH #2/4] c++: mark short-enums as packed Organization: Free thinker, does not speak for AdaCore References: <78e7499c-2278-44ff-8455-503e3690e3fd@redhat.com> <9d922575-6f5a-4458-b3dc-a25dce128e24@redhat.com> <9f88b17b-4202-454c-abbd-6d9c999ceee8@redhat.com> <5f1e4efb-86ad-41e8-b69d-f91961ed6235@redhat.com> Date: Thu, 30 Nov 2023 04:21:40 -0300 In-Reply-To: <5f1e4efb-86ad-41e8-b69d-f91961ed6235@redhat.com> (Jason Merrill's message of "Wed, 29 Nov 2023 14:03:40 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,WEIRD_QUOTING autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Nov 29, 2023, Jason Merrill wrote: > On 11/29/23 04:39, Alexandre Oliva wrote: >> Hello, Jason, >> On Nov 22, 2023, Jason Merrill wrote: >>=20 >>> On 11/22/23 13:12, Jason Merrill wrote: >>>> I'm coming to the conclusion that your C++ patch is fine but we >>>> should remove the TYPE_PACKED warning from >>>> check_address_or_pointer_of_packed_member.=C2=A0 And maybe add >>>> -Wcast-align=3Dstrict to -Wextra. >>=20 >>> Since I seem to have opinions, I'm preparing a patch for this. >> Thanks for that patch. It makes sense to me, but I suppose that, if >> it goes in, I should revert the already-installed #1/4 in this series >> https://gcc.gnu.org/pipermail/gcc-patches/2023-November/637244.html >> rather than install #4/4 that Mike approved. >> https://gcc.gnu.org/pipermail/gcc-patches/2023-November/637336.html >> I wasn't sure whether your earlier conclusion (quoted above) was >> meant >> as an 'Ok' for the C++ patch. Please confirm if so. TIA, > Yes. Thanks, the C++ patch is now in, and so is the testsuite patch reversal. The pr108251 analyzer tests are again failing on -fshort-enum platforms, in hope that your patchset is going to make it. --=20 Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive