From: Alexandre Oliva <oliva@adacore.com>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: fix latent bootstrap-debug issue (modref, tree-inline, tree jump-threading)
Date: Sat, 28 Aug 2021 01:29:53 -0300 [thread overview]
Message-ID: <or8s0mjiny.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <20210822131247.GB68480@kam.mff.cuni.cz> (Jan Hubicka's message of "Sun, 22 Aug 2021 15:12:47 +0200")
On Aug 22, 2021, Jan Hubicka <hubicka@ucw.cz> wrote:
> OK, thanks for looking into this issue!
Thanks, I've finally installed it in the trunk.
> It seems that analye_stmt indeed does not skip debug stmts. It is very
> odd we got so far without hitting build difference.
Indeed. That got me thinking... The comments state:
If the statement cannot be analyzed (for any reason), the entire
function cannot be analyzed by modref.
but the implementation also tests, for every statement:
|| ((!summary || !summary->useful_p (ecf_flags, false))
&& (!summary_lto
|| !summary_lto->useful_p (ecf_flags, false))))
which means that, if the first stmt of a block doesn't add useful
information to the summary, we give up. Was this really the intent?
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>
next prev parent reply other threads:[~2021-08-28 4:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-21 2:50 Alexandre Oliva
2021-08-22 13:12 ` Jan Hubicka
2021-08-28 4:29 ` Alexandre Oliva [this message]
2021-08-28 17:48 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=or8s0mjiny.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).