From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id 8B4A6383A629 for ; Mon, 20 Nov 2023 08:40:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8B4A6383A629 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8B4A6383A629 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::230 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700469638; cv=none; b=nUpY5A1I4+STjE3xUpXpaBfpfkV/GzcvGTkl7skRXdwEaVs+JfBXY8vTbmArdPO2K8XK3X870yUwNkZLKbqVAHJMaT5sbQNNhmXvR6m4QaVqK13mLPJnWZ8gYUTLhRtDkeuOKcQvFLVigewdrQb8Y6fzApjgg0UNZUkLx5FyfwE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700469638; c=relaxed/simple; bh=tcCnq13o1qA8Cooq8nb4KotaVCTm0NU0JNP3sMiUFCo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ZpYm0+x64IqnNUZ7JZweIPbwZB3A7ra54tL/82UYh8zYwAQG/a8/LfBOJod2sigbjpMgiNupOpAoxFJywsN415jEDffmGh73+QuUspKbFuUitngrowPc5K5vKyXN8VSMvc5155d7IBeX54XMzfXZJI7ab4/t1m9zSoFJuSh/dO0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x230.google.com with SMTP id 5614622812f47-3b2e330033fso2826816b6e.3 for ; Mon, 20 Nov 2023 00:40:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1700469636; x=1701074436; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=jSh4RGTT4xdCfPpqi9bQHt5RLOllbZCWTcFPF6z1B9A=; b=P7LzhP2ZfILKvchMxzmFYntcS4rn+/jMvRaQJi6qje/E34tsL0aj5wiebW8O+QOOTE KB/JguxVMSMMDRvFtMZU+pRmCyL1Yxl44sar2HzzPdnJ6BYFPDS/Z2o5XkkwQ968JTC2 a2jhWA795LkRcVsHsQErcCi3GIkTH3dEV2wgRom0XFO6X5BRrhA0esehHqGcKrnpMytz rxnlK7zYUu+3EiHer/Gxzpfj0ZQC7trFvi1y5/sibFwtOYXqvB1Sq4nmJeHSy9skQ2b2 BIGptK69lzBHCVnY1GY2AJw4d5uvbA/r3I1NqaOEVIn5uH4KdiXkoE4J9hUdlSoGi4Ks 7gIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700469636; x=1701074436; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jSh4RGTT4xdCfPpqi9bQHt5RLOllbZCWTcFPF6z1B9A=; b=pbF907Pe8O2PCQyWZNbPGT67HoeX6kY0n+uq5Fr21iLzWw2w3U2nC4sUzK8x6UQZzv 8WYbPYhFzV3Iil7pN6s5tWLSCtA77xO8CZNdeQnYabV0hSC9ofBSdPqnnpjex15KTZ+7 5fjO8iAiKUJ3dwNxYcOIfIVGX+GZZYvWbtYK+cEjfR5YU/wxX/MnKLsqbcKTmDGxvyFe jsquOgybjOtnHMIF2XJ1pW4uGDfj14/LwJWe7MBfA1oXCjBsThxFLPbNnN4GgE5eolzG N/Wf35dIncsjtGSSMWanuvciWm/lP6hRwipJME5JGNBRLsS4oJaZHHDqnXaD7Jhcmo1D 6zrQ== X-Gm-Message-State: AOJu0Yy4HOUI53Qif3HkZyLnm8ANFSX2kS/qpaMtfpogYE18dDgHDuMd 0EtEQaQgq8J4sJkFJ+6W8X5+gg== X-Google-Smtp-Source: AGHT+IGjxdl70vqty+fk84hn25meMu6t1wrpjgWLccwp6eE+bMgxNS6jAUlsqaX3/yn4Q3CMG6BQgg== X-Received: by 2002:a05:6808:178c:b0:3ae:50f7:e3a4 with SMTP id bg12-20020a056808178c00b003ae50f7e3a4mr10452310oib.22.1700469635929; Mon, 20 Nov 2023 00:40:35 -0800 (PST) Received: from free.home ([2804:7f1:2080:51b3:d545:cbee:40c0:c7a7]) by smtp.gmail.com with ESMTPSA id fd26-20020a056a002e9a00b00688435a9915sm5548794pfb.189.2023.11.20.00.40.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 00:40:35 -0800 (PST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 3AK8eHUv155995 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 20 Nov 2023 05:40:18 -0300 From: Alexandre Oliva To: Jeff Law Cc: gcc-patches@gcc.gnu.org, Nick Clifton , Richard Earnshaw , Ramana Radhakrishnan , Kyrylo Tkachov , Rainer Orth , Mike Stump Subject: Re: [committed] [PATCH] testsuite: arm: fix arm_movt cut&pasto Organization: Free thinker, does not speak for AdaCore References: Date: Mon, 20 Nov 2023 05:40:16 -0300 In-Reply-To: (Jeff Law's message of "Sun, 19 Nov 2023 20:19:53 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Nov 20, 2023, Jeff Law wrote: > On 11/19/23 19:33, Alexandre Oliva wrote: >> (check_effective_target_arm_arch_v6t2_hw_ok): Likewise. Richard Earnshaw had already fixed this bit, so I installed only the remaining hunk: testsuite: arm: fix arm_movt cut&pasto I got spurious fails of tests that required arm_thumb1_movt_ok on a target cpu that did not support movt. Looking into it, I found the arm_movt property to have been cut&pasted into other procs that checked for different properties. They shouldn't share the same test results cache entry, so I'm changing their prop names. Or rather its prop name, because the other occurrence was already fixed recently. for gcc/testsuite/ChangeLog * lib/target-supports.exp (check_effective_target_arm_thumb1_cbz_ok): Fix prop name cut&pasto. --- gcc/testsuite/lib/target-supports.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index 7412ac95623f3..4b647d6a88e14 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -5592,7 +5592,7 @@ proc check_effective_target_arm_thumb1_movt_ok {} { proc check_effective_target_arm_thumb1_cbz_ok {} { if [check_effective_target_arm_thumb1_ok] { - return [check_no_compiler_messages arm_movt object { + return [check_no_compiler_messages arm_cbz object { int foo (void) { -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive