From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 84FE23858D32 for ; Tue, 16 Apr 2024 03:55:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 84FE23858D32 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 84FE23858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::631 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713239735; cv=none; b=otH7QOwW08D8sBpdYfIiMP2qgfHvtnvcWXvxAljkUA3f/9f26aEL6rZ0V+hFOgVlw9tLAKhjQJW/N3zFDSPOP4ZnDLb6SojntRlp5Rnq2MWI8zq70oaUj+AWW7SMV2N0QpXwCWP0q4zZlF7PkvhCbUdFylPOB8z93PFpNnqfhOo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713239735; c=relaxed/simple; bh=E8Rq9zeAHESDj2aKQiqiMPVYIBdd4JKyqVtryIUgmt0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=i3cYrFyd18AndeftXOb5NVMF00jJWrkwIwsa+WYIKe7vY3rJBnaATOKhgLFVzRNeNtuFlnWjh6QQxIWEnTvC9lzH+XAdNeEOtePmmreE442IaC8P16O4qLVnLDOTKm/1OAyzrcUb/x3j4C5JNhrZHkKTXIO1sextA4ILDkUE990= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1e5c7d087e1so23945895ad.0 for ; Mon, 15 Apr 2024 20:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1713239732; x=1713844532; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:organization:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=5ppMlLGD9QVHn+TKuCY0PvFqpmafdRZfgKL9+ds4TcA=; b=i7WjxVNzfmHU9sYCByuW4nsL8ESrivSaKvtUZqbBPw5Yowp1ss6zqVL5MvWQD2cQJf ZbzuSp9IciEGUS8V5YuEdaTys7t/uVFZ6DoQZYn7xHCEIHedtEgp6vjUGZ5z2o58Vhcx WzWAVa6TDXWyI9GdXLHFvj8pGvUCqw0QRjTWODxfsKZkNk6+CzWEgY9NXh0miCTtxdYw 8iYSLpBPwU7XKhXBrPsb+JYZn/Dt24gq03Gw5rbNq8umN192MOA10geDDLKVOpF8kzRP dfyRDAPTPJqVEbP1xXuRwgqTjRa39Hq205xNcFJfjzl+bR2EoerfnuLFeljN028gwzoS aPyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713239732; x=1713844532; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:organization:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5ppMlLGD9QVHn+TKuCY0PvFqpmafdRZfgKL9+ds4TcA=; b=LIEtOTYjsMq5MZ7M17KvfDuPJR9f2BY4X8D7oIu3LcB5RNC4TUKVhGQqilXKkeAdE0 UulsuD0t/TCHa+ZgWuuibvcXY+bXVVt9KMAJU22ELgG/kwad8klE9eMdyE0cwnb6vQjH WUtGYl2jgboa1NMryYDK8/oEMYDD0/peUcXS2hMR/nlQUIpE31Ry1kr/F/5kd27DCNkv J2OmXgqqNUSrbuvQGEQ21L/aeDx2Hp6RhOs0RB+2EtQfEKHx+A3LsZD/iaJnQMl+b+kY iwUSYcaUDeNCn432yvuH/rcQhO/d68XhrVjxpEcbTQYLJFH56QDeQT/fdDrCKreHz7+L yneg== X-Gm-Message-State: AOJu0YzXC1MpeSwABQ8jU/dROgof9jKOfhzbO/58KJ3kXNdk766gNmtN sRVBQn26LwlUcehT9UQmUsG5a56XTVc9AqRSMEBqX5Si9mY9Tq/mbRMcrdK6NdsMBjrDrIbSCac jag== X-Google-Smtp-Source: AGHT+IGb6tfdi7cGKKwVPLcizLzVSjatWY+BNqiu9l2M9kyfC5RpL7ItgsCLcGOmJDMUP/v1GeqDaQ== X-Received: by 2002:a17:903:41c7:b0:1e3:e137:d3af with SMTP id u7-20020a17090341c700b001e3e137d3afmr13388314ple.9.1713239732271; Mon, 15 Apr 2024 20:55:32 -0700 (PDT) Received: from free.home ([2804:7f1:218b:5e2:c43b:e0c4:71a:241b]) by smtp.gmail.com with ESMTPSA id g21-20020a170902c39500b001e7b7a79340sm899769plg.267.2024.04.15.20.55.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 20:55:31 -0700 (PDT) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 43G3tMZ52388554 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 16 Apr 2024 00:55:22 -0300 From: Alexandre Oliva To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] [strub] improve handling of indirected volatile parms [PR112938] Organization: Free thinker, does not speak for AdaCore References: Date: Tue, 16 Apr 2024 00:55:21 -0300 In-Reply-To: (Richard Biener's message of "Mon, 11 Mar 2024 08:26:27 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mar 11, 2024, Richard Biener wrote: > On Sat, Mar 9, 2024 at 10:10=E2=80=AFAM Alexandre Oliva wrote: >>=20 >>=20 >> The earlier patch for PR112938 arranged for volatile parms to be made >> indirect in internal strub wrapped bodies. >>=20 >> The first problem that remained, more evident, was that the indirected >> parameter remained volatile, despite the indirection, but it wasn't >> regimplified, so indirecting it was malformed gimple. >>=20 >> Regimplifying turned out not to be needed. The best course of action >> was to drop the volatility from the by-reference parm, that was being >> unexpectedly inherited from the original volatile parm. >>=20 >> That exposed another problem: the dereferences would then lose their >> volatile status, so we had to bring volatile back to them. >>=20 >> Regstrapped on x86_64-linux-gnu. Ok to install? > OK Thanks, sorry, I dropped the ball on this one. I'm going to put it in momentarily. It had been approved for gcc 14, before it branched off; should I install it there as well? >>=20 >> for gcc/ChangeLog >>=20 >> PR middle-end/112938 >> * ipa-strub.cc (pass_ipa_strub::execute): Drop volatility from >> indirected parm. >> (maybe_make_indirect): Restore volatility in dereferences. >>=20 >> for gcc/testsuite/ChangeLog >>=20 >> PR middle-end/112938 >> * g++.dg/strub-internal-pr112938.cc: New. --=20 Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive