From: Alexandre Oliva <oliva@adacore.com>
To: Bernd Edlinger <bernd.edlinger@hotmail.de>
Cc: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
"gcc-patches\@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Mike Stump <mikestump@comcast.net>,
David Edelsohn <dje.gcc@gmail.com>
Subject: Re: [PATCH] testsuite: Fix test failures from outputs.exp [PR98225]
Date: Fri, 08 Jan 2021 05:52:32 -0300 [thread overview]
Message-ID: <orbldzyfn3.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <AM0PR0602MB341079EE60B2F32B564658B5E4AF0@AM0PR0602MB3410.eurprd06.prod.outlook.com> (Bernd Edlinger's message of "Thu, 7 Jan 2021 23:18:46 +0100")
On Jan 7, 2021, Bernd Edlinger <bernd.edlinger@hotmail.de> wrote:
> I don't know why that is there in the first place, as there
> are no C++ test cases, these files should not be created at all.
collect2, on platforms that use it, create .cdtor files even for C.
David Edelsohn told me so back then; the problem was on AIX IIRC. That
was why I added code to tolerate such outputs. Removing it would likely
bring that failure back.
> Is it OK for trunk?
It looks good to me, aside from the removal of the .cdtor handler.
I don't think I have authority to approve it with that change,
but I would if I did ;-) Thanks!
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Vim, Vi, Voltei pro Emacs -- GNUlius Caesar
next prev parent reply other threads:[~2021-01-08 8:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 8:48 [PATCH] Fix test failures from outputs.exp (PR testsuite/98225) Bernd Edlinger
2021-01-07 16:12 ` Rainer Orth
2021-01-07 22:18 ` [PATCH] testsuite: Fix test failures from outputs.exp [PR98225] Bernd Edlinger
2021-01-08 8:52 ` Alexandre Oliva [this message]
2021-01-11 12:11 ` Rainer Orth
2021-01-08 14:23 ` David Edelsohn
2021-01-08 18:59 ` [PATCH v2] " Bernd Edlinger
2021-01-08 19:27 ` David Edelsohn
2021-01-11 11:13 ` Bernd Edlinger
2021-01-11 12:13 ` Rainer Orth
2021-02-16 1:33 ` Committed: gcc.misc-tests/outputs.exp (outest): Fix typo "is_target" Hans-Peter Nilsson
2021-02-16 7:35 ` Bernd Edlinger
2021-02-16 10:48 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=orbldzyfn3.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=bernd.edlinger@hotmail.de \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikestump@comcast.net \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).