From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id DCC2F3844026 for ; Fri, 8 Jan 2021 08:52:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DCC2F3844026 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oliva@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9536F560D2; Fri, 8 Jan 2021 03:52:42 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id OVc5lwo02h3b; Fri, 8 Jan 2021 03:52:42 -0500 (EST) Received: from free.home (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id 52AE81173FF; Fri, 8 Jan 2021 03:52:42 -0500 (EST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 1088qWJq051304 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 8 Jan 2021 05:52:33 -0300 From: Alexandre Oliva To: Bernd Edlinger Cc: Rainer Orth , "gcc-patches\@gcc.gnu.org" , Mike Stump , David Edelsohn Subject: Re: [PATCH] testsuite: Fix test failures from outputs.exp [PR98225] Organization: Free thinker, does not speak for AdaCore References: Errors-To: aoliva@lxoliva.fsfla.org Date: Fri, 08 Jan 2021 05:52:32 -0300 In-Reply-To: (Bernd Edlinger's message of "Thu, 7 Jan 2021 23:18:46 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2021 08:52:44 -0000 On Jan 7, 2021, Bernd Edlinger wrote: > I don't know why that is there in the first place, as there > are no C++ test cases, these files should not be created at all. collect2, on platforms that use it, create .cdtor files even for C. David Edelsohn told me so back then; the problem was on AIX IIRC. That was why I added code to tolerate such outputs. Removing it would likely bring that failure back. > Is it OK for trunk? It looks good to me, aside from the removal of the .cdtor handler. I don't think I have authority to approve it with that change, but I would if I did ;-) Thanks! -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar