From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id B01C5385DC3F for ; Thu, 18 Apr 2024 14:45:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B01C5385DC3F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B01C5385DC3F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713451551; cv=none; b=OqxNDY08dw8TLeQh/YFdNi2eiAmNjVefADWlGFDgM4DQOhJpEfsqBya0eQ/MR8OplLpiWrU7KqEtkLvnPyTBWBXDtR/OO13xE2r0764/Gapojoe2+oSOhU2R/PbYAnzHkVSf8SFGQFqRTQvLQnshMZ6ZkAh+luKGIpsziCa1k30= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713451551; c=relaxed/simple; bh=hqJQtD7/eabaPz93rbCwgpF2Sf/lymxQgLMfJY6ShJE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=rBZIFB8r5jDRQ5bq/e29fpTWUDrUVeaoshfbZC5iaJKa/7Jm206UtQoPE7ysJrrVZCCyPT0CWv/yBhWryUtgg/M9k6APRNWKlg1areGvvC/6dCkHkUPFYGBiMzeGk2yapWtpbFVhy0Xt108uLtGEDlr8yuzJfdJ/BJ4VN0wR3Ro= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-6ecf1bb7f38so978988b3a.0 for ; Thu, 18 Apr 2024 07:45:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1713451544; x=1714056344; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=3uFWait7XMaMEzvqfSLLEhNZ2iL1CcFam6TRX0Mxks0=; b=SgJ70wjtJf7KD+nsjtM+HNH5rT2NmdLHB642/5seD/B5g/xbfmhwAYXsTs8xYHqMdt DVJatLo3S50fwcrM6o1jiyFUzeoT6ABrUXuT0AbjFsqxZ6rRWBuEyewRDQCa6y939jXz v4i3+QLvPqHDRg8ig7bpNI16ylD+jFdXBj8IQufTDQOr4sJS8zrLgxfcDzwJKK8tlZpj cDeS23kJSDLHGSeRlXm5arc7G5qO7+L5o8Axp+1mP/73UmWzq+ff5z1rqafaUmozuBJL cIr6C5V7h05OU6S3LvFrDpaCnr0MRHhX0T/KB7a26NKCaM0zkACiBWH4BXzCKE2szuUc ufbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713451544; x=1714056344; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3uFWait7XMaMEzvqfSLLEhNZ2iL1CcFam6TRX0Mxks0=; b=KG3BeazDQMM/ajZ2XXgV6Zvt+mQcyHr7EsOCWl7QKJkQiHFEoRNwTLwzAiB0AlLehw lDsRPn2FJF+WA4jBvuhvBZ/0QPRPnRydA2BQjbLjczhVDF4gbb+W89Q90vhfmsHziDNY uYW4AojSdKDRxXBG/GNXkfS9SZpLuEYZO2zHdTb6XOFKdHaXRmnzsxl6FPCaptJomvob ClS5wJCZhngNDL8o6+lj2sv4/fQ48E1Mft/90FmF5KEcaI/y19lZvKsljHwGOcLwiBiz ub5KalvVuqNizdGQ0GIX92KmkTZDKLBXH++DJdoENlcGXxXGkTUBSdem2QCAGX7PuIWR 4pUA== X-Gm-Message-State: AOJu0YyPjhxFUHRrKjQuvVa5cgr0PcqS0Bs9/IH9jVUT56Q/WfwivslJ 3sRl7XhKdN8jvG8Rm//7au7USrMU6hNrS4hCE8nw1JjP1kOK515dki/Xzyqr1A== X-Google-Smtp-Source: AGHT+IEesEyTD69sDPW8di2dEQv23F/NaXAUB7chqr3fo3HLONHd16NGBP6K7bx8IlxK9Al4vRu6Mg== X-Received: by 2002:a05:6a20:43a4:b0:1aa:5f30:9765 with SMTP id i36-20020a056a2043a400b001aa5f309765mr4066613pzl.44.1713451543463; Thu, 18 Apr 2024 07:45:43 -0700 (PDT) Received: from free.home ([2804:7f1:218b:5e2:c43b:e0c4:71a:241b]) by smtp.gmail.com with ESMTPSA id x23-20020a056a00189700b006edadf8058asm1560898pfh.23.2024.04.18.07.45.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 07:45:43 -0700 (PDT) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 43IEjUO12483827 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 18 Apr 2024 11:45:31 -0300 From: Alexandre Oliva To: Jonathan Wakely Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PATCH] [libstdc++] introduce --disable-compat-libstdcxx-abi Organization: Free thinker, does not speak for AdaCore References: Date: Thu, 18 Apr 2024 11:45:30 -0300 In-Reply-To: (Jonathan Wakely's message of "Tue, 16 Apr 2024 07:55:11 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Apr 16, 2024, Jonathan Wakely wrote: >> +dnl >> +dnl Enable -Wabi=2 if not overridden by --disable-compat-libstdcxx-abi. >> +dnl >> +AC_DEFUN([GLIBCXX_ENABLE_WABI], [ >> + # Default. >> + WARN_FLAGS_WABI=\ -Wabi=2 >> + AC_MSG_CHECKING([for --disable-compat-libstdcxx-abi]) >> + AC_ARG_ENABLE([compat-libstdcxx-abi], > We have the GLIBCXX_ENABLE macro to simplify creating new --enable options. *nod*. There was some reason why I didn't use it at first. Maybe it can be used with the patch as it ended up. Will revisit. >> + AC_HELP_STRING([--disable-compat-libstdcxx-abi], >> + [Disable backward-compatibility ABI symbols)]), > There's a stray ')' here. Ugh, thanks >> --- a/libstdc++-v3/doc/html/manual/configure.html >> +++ b/libstdc++-v3/doc/html/manual/configure.html > This should be in doc/xml/manual/configure.xml too, which is used to > generate the HTML using docbook. Oh, right. Doh. So much for grepping for an existing option and jumping to edit the first match :-) > The description here in the docs (and the name of the configure > option) seem much too vague. Libstdc++ has dozens, probably hundreds, > of "backward-compatibility ABI symbols", and this only affects touches > a tiny handful of them. Just the aliases created automatically by the > compiler for mangling changes, right? Yeah. I had used --disable-libstdcxx-Wabi at some point, maybe that's better. FTR, we now have a binutils patch (thanks H.J.Lu) to address the underlying problem, so we'll probably no longer need the workaround that led me to propose this change. I wonder if there's interest in keeping it. I'd be equally happy to make the adjustments, or to withdraw it (or pretty much anything in between ;-). WDYT? -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive