Fix VxWorks xfail filters on pthread-init-?.c

Fix VxWorks xfail filters on pthread-init-?.c

[Alexandre Oliva]

Match xfail on kernel instead of rtp mode.

Regstrapped on x86_64-linux-gnu, and tested with -x-arm-wrs-vxworks7r2.
Ok to install?


from Olivier Hainque <hainque@adacore.com>
for  gcc/testsuite/changeLog

	* gcc.dg/pthread-init-1.c: Fix the VxWorks xfail filters.
	* gcc.dg/pthread-init-2.c: Ditto.
---
 gcc/testsuite/gcc.dg/pthread-init-1.c |    6 +++---
 gcc/testsuite/gcc.dg/pthread-init-2.c |    3 +++
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/gcc/testsuite/gcc.dg/pthread-init-1.c b/gcc/testsuite/gcc.dg/pthread-init-1.c
index 8b600c3fb87bf..3346c926c8ee3 100644
--- a/gcc/testsuite/gcc.dg/pthread-init-1.c
+++ b/gcc/testsuite/gcc.dg/pthread-init-1.c
@@ -7,9 +7,9 @@
 /* { dg-do compile } */
 /* { dg-require-effective-target pthread_h } */
 /* { dg-options "-Wextra -Wall" } */
-/* The RTP definition of PTHREAD_MUTEX_INITIALIZER is missing an
- * initializer for mutexAttr.mutexAttrType.  */
-/* { dg-xfail-if "missing initializer" { vxworks_rtp } } */
+/* The definition of PTHREAD_MUTEX_INITIALIZER is missing an initializer for
+   mutexAttr.mutexAttrType in kernel mode for various VxWorks versions.  */
+/* { dg-xfail-if "missing initializer" { vxworks_kernel } } */
 
 #include "pthread-init-common.h"
 
diff --git a/gcc/testsuite/gcc.dg/pthread-init-2.c b/gcc/testsuite/gcc.dg/pthread-init-2.c
index 8ec0515ba26e1..d7cd66b5c0272 100644
--- a/gcc/testsuite/gcc.dg/pthread-init-2.c
+++ b/gcc/testsuite/gcc.dg/pthread-init-2.c
@@ -9,6 +9,9 @@
 /* { dg-options "-Wextra -Wall -ansi" } */
 /* { dg-options "-Wextra -Wall -ansi -D_POSIX_C_SOURCE=199506L" { target { *-*-hpux* } } } */
 /* { dg-options "-Wextra -Wall -ansi -D_XOPEN_SOURCE=500" { target { powerpc-ibm-aix* } } } */
+/* The definition of PTHREAD_MUTEX_INITIALIZER is missing an initializer for
+   mutexAttr.mutexAttrType in kernel mode for various VxWorks versions.  */
+/* { dg-xfail-if "missing initializer" { vxworks_kernel } } */
 
 #include "pthread-init-common.h"
 


-- 
Alexandre Oliva, happy hacker  https://FSFLA.org/blogs/lxo/
   Free Software Activist         GNU Toolchain Engineer
        Vim, Vi, Voltei pro Emacs -- GNUlius Caesar

Re: Fix VxWorks xfail filters on pthread-init-?.c

[Mike Stump]

On Dec 22, 2020, at 1:34 PM, Alexandre Oliva <oliva@adacore.com> wrote:
> Match xfail on kernel instead of rtp mode.
> 
> Regstrapped on x86_64-linux-gnu, and tested with -x-arm-wrs-vxworks7r2.
> Ok to install?

Ok.

Longer term, would be nice to fix includes the relevant file to have the relevant definition.

Re: Fix VxWorks xfail filters on pthread-init-?.c

[Alexandre Oliva]

On Dec 29, 2020, Mike Stump <mikestump@comcast.net> wrote:

> On Dec 22, 2020, at 1:34 PM, Alexandre Oliva <oliva@adacore.com> wrote:
>> Match xfail on kernel instead of rtp mode.
>> 
>> Regstrapped on x86_64-linux-gnu, and tested with -x-arm-wrs-vxworks7r2.
>> Ok to install?

> Ok.

Thanks

> Longer term, would be nice to fix includes the relevant file to have
> the relevant definition.

We tend to avoid fixincludes for these targets.

IIUC (some guessing here) there are several reasons for that:

- it would have to run on customer's premises, on hosts that don't
  necessarily have the tools requires for fixincludes runs

- the fixincluded headers hidden in our installed tools would lag
  behind, unchanged and potentially incompatible, after customers update
  or reconfigure the target system

- the license of the target system headers doesn't seem to allow
  modifications

So we tend to work around and report upstream problems we identify in
their header files.

-- 
Alexandre Oliva, happy hacker  https://FSFLA.org/blogs/lxo/
   Free Software Activist         GNU Toolchain Engineer
        Vim, Vi, Voltei pro Emacs -- GNUlius Caesar