From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21465 invoked by alias); 13 Jun 2012 22:00:52 -0000 Received: (qmail 21450 invoked by uid 22791); 13 Jun 2012 22:00:49 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Jun 2012 22:00:30 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5DM0Tlr030309 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Jun 2012 18:00:30 -0400 Received: from freie.oliva.athome.lsd.ic.unicamp.br (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q5DM0Sfj024470 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 13 Jun 2012 18:00:29 -0400 Received: from livre.localdomain (livre-to-gw.oliva.athome.lsd.ic.unicamp.br [172.31.160.19]) by freie.oliva.athome.lsd.ic.unicamp.br (8.14.5/8.14.5) with ESMTP id q5DM0R4Q008731; Wed, 13 Jun 2012 19:00:27 -0300 Received: from livre.localdomain (aoliva@localhost.localdomain [127.0.0.1]) by livre.localdomain (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id q5DM0QdC013072; Wed, 13 Jun 2012 19:00:26 -0300 Received: (from aoliva@localhost) by livre.localdomain (8.14.3/8.14.3/Submit) id q5DM0P13013071; Wed, 13 Jun 2012 19:00:25 -0300 From: Alexandre Oliva To: ayal.zaks@gmail.com Cc: gcc-patches@gcc.gnu.org Subject: Re: debug insns in SMS References: Date: Wed, 13 Jun 2012 22:08:00 -0000 In-Reply-To: (Alexandre Oliva's message of "Mon, 09 Apr 2012 03:53:14 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-06/txt/msg00881.txt.bz2 Apologies for the duplicate ping, this one is now properly addressed to the pass maintainer. On Apr 9, 2012, Alexandre Oliva wrote: > On May 4, 2011, Revital1 Eres wrote: >> Hello Alexandre >>> I think this will restore proper functioning to SMS in the presence of >>> debug insns. A while ago, we'd never generate deps of non-debug insns >>> on debug insns. I introduced them to enable sched to adjust (reset) >>> debug insns when non-debug insns were moved before them. I believe it >>> is safe to leave them out of the SCCs. Even though this will end up >>> causing some loss of debug info, that's probably unavoidable, and the >>> end result after this change is pobably the best we can hope for. Your >>> thoughts? >> Thanks for the patch! >> I actually discussed this issue with Ayal yesterday. >> Ayal also suggested to reconsider the edges that are created in >> the DDG between real instructions and debug_insns. Currently, we create >> bidirectional anti deps edges between them. This leads to the problem you >> were trying to solve in the current patch (described below) where these >> extra edges influence the construction of the strongly connected component >> and the code generated with and w\o -g. Your patch seems to solve this >> problem. >> However I can not approve it as I'm not the maintainer (Ayal is). > Ping? > (Retested on x86_64-linux-gnu and i686-pc-linux-gnu) > for gcc/ChangeLog > from Alexandre Oliva > * ddg.c (build_intra_loop_deps): Discard deps of nondebug on debug. Ping? http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00419.html -- Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist Red Hat Brazil Compiler Engineer