public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Alexandre Oliva <aoliva@redhat.com>
To: DJ Delorie <dj@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: stabilize .gcc_except_table with or without -g
Date: Wed, 07 Nov 2007 06:34:00 -0000	[thread overview]
Message-ID: <orfxziva25.fsf@oliva.athome.lsd.ic.unicamp.br> (raw)
In-Reply-To: <200711052041.lA5Kf8lB016106@greed.delorie.com> (DJ Delorie's message of "Mon\, 5 Nov 2007 15\:41\:08 -0500")

On Nov  5, 2007, DJ Delorie <dj@redhat.com> wrote:

>> Should new the compare function be moved into libiberty proper?

> If it were to be moved into libiberty, I think (1) it would need to
> guard against NULL arguments, and (2) it must assume that two strings
> may compare equal.  Libiberty functions shouldn't abort if they can
> return a meaningful error value.

Works for me.

> As for should it be in libiberty... I think it would be reasonable for
> each hash type to have a "stock" implementation of hashing a simple
> string.

But this is not about hashing at all.  We're talking about no more
than a wrapper for strcmp with different static types for the
arguments.  So I'm not sure it's all that useful for libiberty, but I
can see that it could be convenient.  Your call, really.

-- 
Alexandre Oliva         http://www.lsd.ic.unicamp.br/~oliva/
FSF Latin America Board Member         http://www.fsfla.org/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}

      reply	other threads:[~2007-11-07  6:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-05  7:19 Alexandre Oliva
2007-11-05 19:20 ` Mark Mitchell
2007-11-26  9:33   ` Alexandre Oliva
2007-11-05 20:41 ` DJ Delorie
2007-11-07  6:34   ` Alexandre Oliva [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=orfxziva25.fsf@oliva.athome.lsd.ic.unicamp.br \
    --to=aoliva@redhat.com \
    --cc=dj@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).