From: Alexandre Oliva <oliva@adacore.com>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: gcc-patches@gcc.gnu.org, Kito Cheng <kito.cheng@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Andrew Waterman <andrew@sifive.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>,
Raphael Moreira Zinsly <rzinsly@ventanamicro.com>
Subject: Re: [PATCH] RISC-V: Fix CTZ unnecessary sign extension [PR #106888]
Date: Tue, 20 Feb 2024 11:21:57 -0300 [thread overview]
Message-ID: <orh6i3nrlm.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <dfcf8499-5fe7-4262-9cf4-eaca4cb74742@gmail.com> (Jeff Law's message of "Mon, 19 Feb 2024 23:49:48 -0700")
On Feb 20, 2024, Jeff Law <jeffreyalaw@gmail.com> wrote:
> On 2/19/24 21:26, Alexandre Oliva wrote:
>> This backport for gcc-13 is required for pr90838.c to get the expected
>> count of andi instructions on riscv64-elf
.
> In general, shouldn't backports be focused on correctness issues?
*nod*.
> It's unclear what the motivation is for backporting this change into
> gcc-13.
There's this unexpected fail in gcc-13 (pr90838.c), one out of a handful
that we've hit while transitioning our riscv toolchains to gcc-13.
I set out to understand them, I identified the patches that got them to
pass in the trunk, and so I've proposed their backports to fix the fails
in gcc-13.
Surely there are other ways to address each one of the fails.
But even if we choose to just xfail them, or leave them failing noisily,
I've already gone through the process of identifying the fix, so I
figured I might as well share it.
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
More tolerance and less prejudice are key for inclusion and diversity
Excluding neuro-others for not behaving ""normal"" is *not* inclusive
next prev parent reply other threads:[~2024-02-20 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 4:26 Alexandre Oliva
2024-02-20 6:49 ` Jeff Law
2024-02-20 14:21 ` Alexandre Oliva [this message]
2024-02-23 7:14 ` Jeff Law
-- strict thread matches above, loose matches on Subject: below --
2023-05-04 17:14 Raphael Moreira Zinsly
2023-05-06 14:57 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=orh6i3nrlm.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=andrew@sifive.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=jim.wilson.gcc@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=palmer@dabbelt.com \
--cc=rzinsly@ventanamicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).