From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id B82593858439 for ; Wed, 20 Dec 2023 02:33:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B82593858439 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B82593858439 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703039585; cv=none; b=jO3DfxB/o005fFZWMuG9wxrxWlFBQqgcKVAi36ustljx+Z0Ayefa+6OKHd+gfjreycoojfbqjypvPj2wtGRoDEokwLQcaJravrB6E74xzSXoANddTdm8rGN15sxR/Q/fxLcgSd6m18wTQW2Y95Cr3j+Pr8/1aWAPimjpyIw3tTo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703039585; c=relaxed/simple; bh=vCDPpSv3aaOtf0RjRWaXTKi0S6MWWhA3QRxOsiMSGv0=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=mkeOjER4esSEqfnu5z55Kid//QFN9kGwfzSlhQ7NIqDycYwXfjrD1emyr/To7vP9ZZDpAwWilpqacU5ClNIeQ3x4q+APaLrPISr95EFbPcFI/rQ5JPPVXvePuRSEdGYp8E79mzn4owGvOiGrLbqEgRZ8r29WfBlTZ0iGZ7nFevw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from linux-libre.fsfla.org ([2001:470:142:5::54] helo=free.home) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFmON-0000Oi-0T; Tue, 19 Dec 2023 21:33:03 -0500 Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 3BK2Wq1V674129 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 19 Dec 2023 23:32:53 -0300 From: Alexandre Oliva To: Jeff Law Cc: gcc-patches@gcc.gnu.org Subject: [PATCH FYI] -finline-stringops: copy timeout factor from memcmp-1.c test Organization: Free thinker, not speaking for the GNU Project References: <3d8665b0-d9c0-4da6-bb92-194e2b68494c@ventanamicro.com> Date: Tue, 19 Dec 2023 23:32:52 -0300 In-Reply-To: <3d8665b0-d9c0-4da6-bb92-194e2b68494c@ventanamicro.com> (Jeff Law's message of "Sun, 17 Dec 2023 20:51:53 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Jeff, On Dec 18, 2023, Jeff Law wrote: > These are timing sporadically on the embedded platforms. Given they > include a test that has a timeout factor, it seems to me you should > duplicate the timeout factor in the new tests. > Remember when you include another file, the dg- directives in the > other file aren't applied. Thanks for the reminder. Sorry I missed most of them. I added some -finline-stringops tests that included memcmp-1.c, but carried over the timeout factor onto only one such test. Jeff Law kindly pointed that out (thanks!), so here's the fix. Testing on x86_64-linux-gnu. I'll check this in as obvious once testing is done. for gcc/testsuite/ChangeLog * gcc.dg/torture/inline-mem-cmp-1.c: Copy timeout factor from mem-cmp-1.c. * gcc.dg/torture/inline-mem-cpy-1.c: Likewise. --- gcc/testsuite/gcc.dg/torture/inline-mem-cmp-1.c | 1 + gcc/testsuite/gcc.dg/torture/inline-mem-cpy-1.c | 1 + 2 files changed, 2 insertions(+) diff --git a/gcc/testsuite/gcc.dg/torture/inline-mem-cmp-1.c b/gcc/testsuite/gcc.dg/torture/inline-mem-cmp-1.c index a368f0741129d..4bc66597b35a6 100644 --- a/gcc/testsuite/gcc.dg/torture/inline-mem-cmp-1.c +++ b/gcc/testsuite/gcc.dg/torture/inline-mem-cmp-1.c @@ -1,5 +1,6 @@ /* { dg-do run } */ /* { dg-options "-finline-stringops=memcmp -save-temps -g0 -fno-lto" } */ +/* { dg-timeout-factor 2 } */ #include "../memcmp-1.c" diff --git a/gcc/testsuite/gcc.dg/torture/inline-mem-cpy-1.c b/gcc/testsuite/gcc.dg/torture/inline-mem-cpy-1.c index c98e903c1f169..f4952554dd011 100644 --- a/gcc/testsuite/gcc.dg/torture/inline-mem-cpy-1.c +++ b/gcc/testsuite/gcc.dg/torture/inline-mem-cpy-1.c @@ -1,5 +1,6 @@ /* { dg-do run } */ /* { dg-options "-finline-stringops=memcpy -save-temps -g0 -fno-lto" } */ +/* { dg-timeout-factor 2 } */ #include "../memcmp-1.c" /* Yeah, this memcmp test exercises plenty of memcpy, more than any of the -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Disinformation flourishes because many people care deeply about injustice but very few check the facts. Think Assange & Stallman. The empires strike back