From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2f.google.com (mail-oo1-xc2f.google.com [IPv6:2607:f8b0:4864:20::c2f]) by sourceware.org (Postfix) with ESMTPS id 585803857BA4 for ; Fri, 9 Jun 2023 12:26:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 585803857BA4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-oo1-xc2f.google.com with SMTP id 006d021491bc7-55b2fb308bbso971992eaf.1 for ; Fri, 09 Jun 2023 05:26:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1686313597; x=1688905597; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:errors-to:references:organization:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=dZGY9LYabtnDg783zDiTohR9+E8sdhpXgnAjiKM05nA=; b=EIGgGlJDbcQEWzlmtZxc3O29ZBzwZpZKoPDAKWi8w2t2wPnjX7oC9Yly1+TN0r3XL6 Vdh6UWK2TE31MRugiHYpbcrBP4hKbA3j8uql3638gxznYMg/+KKEra1scVdfSCAAFr6N F0BvsXAxwiMOuAx8Mcsc8Gp6MgqEzzKuZk3hG2rpPWChEBHAOdhXZuNj4XEmLXwgw77+ g7rsSPGsAHPHTv6ASuObtcqRafeAxLvw8BRSrqeARjCSrKMoB80Nu7Xzi/ZcOAVAQFrh OQWxJOEQSWRlKO1tNgFQ05maWcxwfXuSIicNTamMoP9mvNsbybL5KCzt3wXghG+VOsBu TQiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686313597; x=1688905597; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:errors-to:references:organization:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dZGY9LYabtnDg783zDiTohR9+E8sdhpXgnAjiKM05nA=; b=BiNEI04xBMI36FpCqry8m+DOuxMkTMnWiqL793wQ5zkC5s8Xg9AJ5A+AjbBdAjJpt7 PMpIldcJ/2E+j8nUnBBko7VqVvMLApJoLveVBVABu7ujGn5ohDLb++r6WKi8pJM7/dNV eXSHZ9tzw9ghL4aLdhKXpZoHq+UXPvNNxFwyvD80MkZ4E3fDjHg418YXlI7paxEfik1j B+H7enqnUposW58Py9pn0EzODfQfI1ZZimvwMwWGD+GA5rKo8niwgL03e/74s1+wmniH Fdan7bSFJaUPmcP+yjaUtGDlyiv1fq5i2o940if+H/EYsfRaradjTkNkdJOY1NA6wfRq s2eQ== X-Gm-Message-State: AC+VfDwYeP7QXDHvnS/a3V9jnhjW8lc4BZ4SR4bn4xV6JmgOeiBZ7f47 Q+SAGbO11YDQXor/tenjLlY1qA== X-Google-Smtp-Source: ACHHUZ5U3+TiyzGLgmvCivw6S4UztpTB8vqal2nJZK+xAgrkzs90L6Hx3IFKZ86kxVjQlGAljD0HSw== X-Received: by 2002:a05:6870:1a8a:b0:19f:61c0:c52b with SMTP id ef10-20020a0568701a8a00b0019f61c0c52bmr926219oab.0.1686313597708; Fri, 09 Jun 2023 05:26:37 -0700 (PDT) Received: from free.home ([2804:7f1:2080:a74a:92d8:3534:d404:8561]) by smtp.gmail.com with ESMTPSA id bw9-20020a056820020900b00541fbbbcd31sm738974oob.5.2023.06.09.05.26.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jun 2023 05:26:37 -0700 (PDT) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 359CQTWf092574 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 9 Jun 2023 09:26:30 -0300 From: Alexandre Oliva To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] fix frange_nextafter odr violation Organization: Free thinker, does not speak for AdaCore References: Errors-To: aoliva@lxoliva.fsfla.org Date: Fri, 09 Jun 2023 09:26:29 -0300 In-Reply-To: (Richard Biener's message of "Fri, 9 Jun 2023 11:03:42 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Jun 9, 2023, Richard Biener wrote: > On Thu, Jun 8, 2023 at 4:38=E2=80=AFPM Alexandre Oliva via Gcc-patches > wrote: >> C++ requires inline functions to be declared inline and defined in >> every translation unit that uses them. frange_nextafter is used in >> gimple-range-op.cc but it's only defined as inline in >> range-op-float.cc. Drop the extraneous inline specifier. > OK >> for gcc/ChangeLog >>=20 >> * range-op-float.cc (frange_nextafter): Drop inline. >> (frelop_early_resolve): Add static. >> (frange_float): Likewise. The problem is also present in gcc-13. Ok there as well? Regstrapped on x86_64-linux-gnu. --=20 Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Disinformation flourishes because many people care deeply about injustice but very few check the facts. Ask me about