From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTPS id 9B5D23858C52 for ; Mon, 11 Apr 2022 23:54:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9B5D23858C52 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6C97B116F67; Mon, 11 Apr 2022 19:54:25 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id G+yak7t-r5aD; Mon, 11 Apr 2022 19:54:25 -0400 (EDT) Received: from free.home (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id 2D66B116156; Mon, 11 Apr 2022 19:54:25 -0400 (EDT) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 23BNsEBF2074739 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Apr 2022 20:54:16 -0300 From: Alexandre Oliva To: HAO CHEN GUI via Gcc-patches Cc: HAO CHEN GUI , Bill Schmidt , David , Segher Boessenkool Subject: Re: Ping^2 [PATCH, rs6000] Correct match pattern in pr56605.c Organization: Free thinker, does not speak for AdaCore References: <78123ff3-b69b-5b87-97c5-bea894e0601f@linux.ibm.com> <366b1a50-4a31-1983-dfe6-aa85a8d7506c@linux.ibm.com> Errors-To: aoliva@lxoliva.fsfla.org Date: Mon, 11 Apr 2022 20:54:14 -0300 In-Reply-To: <366b1a50-4a31-1983-dfe6-aa85a8d7506c@linux.ibm.com> (HAO CHEN GUI via Gcc-patches's message of "Fri, 8 Apr 2022 09:34:04 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2022 23:54:27 -0000 On Apr 7, 2022, HAO CHEN GUI via Gcc-patches wro= te: > Gentle ping this: > https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590958.html > Thanks >> On 28/2/2022 =E4=B8=8A=E5=8D=88 11:17, HAO CHEN GUI wrote: >>> This patch corrects the match pattern in pr56605.c. The former pattern >>> is wrong and test case fails with GCC11. It should match following insn= on >>> each subtarget after mode promotion is disabled. The patch need to be >>> backported to GCC11. >>> -/* { dg-final { scan-rtl-dump-times {\(compare:CC \((?:and|zero_extend= ):(?:DI) \((?:sub)?reg:[SD]I} 1 "combine" } } */ >>> +/* { dg-final { scan-rtl-dump-times {\(compare:CC \(and:SI \(subreg:SI= \(reg:DI} 1 "combine" } } */ How about this less strict change instead? ppc: testsuite: PROMOTE_MODE fallout pr56605 [PR102146] The test expects a compare of DImode values, but after the removal of PROMOTE_MODE from rs6000/, we get SImode. Adjust the expectations. Tested with gcc-11 targeting ppc64-vx7r2. Ok to install? for gcc/testsuite/ChangeLog PR target/102146 * gcc.target/powerpc/pr56605.c: Accept SImode compare operand. --- gcc/testsuite/gcc.target/powerpc/pr56605.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.target/powerpc/pr56605.c b/gcc/testsuite/gcc= .target/powerpc/pr56605.c index fdedbfc573dd8..7695f87db6f66 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr56605.c +++ b/gcc/testsuite/gcc.target/powerpc/pr56605.c @@ -11,5 +11,5 @@ void foo (short* __restrict sb, int* __restrict ia) ia[i] =3D (int) sb[i]; } =20 -/* { dg-final { scan-rtl-dump-times {\(compare:CC \((?:and|zero_extend):(?= :DI) \((?:sub)?reg:[SD]I} 1 "combine" } } */ +/* { dg-final { scan-rtl-dump-times {\(compare:CC \((?:and|zero_extend):(?= :[SD]I) \((?:sub)?reg:[SD]I} 1 "combine" } } */ =20 --=20 Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Disinformation flourishes because many people care deeply about injustice but very few check the facts. Ask me about