public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Alexandre Oliva <aoliva@redhat.com>
To: Jason Merrill <jason@redhat.com>
Cc: gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: RFA: PATCH to use -std=c++98 in stage 1 of bootstrap
Date: Wed, 20 May 2015 22:16:00 -0000	[thread overview]
Message-ID: <oriobmq4q8.fsf@livre.home> (raw)
In-Reply-To: <555CC048.8070209@redhat.com> (Jason Merrill's message of "Wed,	20 May 2015 13:11:36 -0400")

On May 20, 2015, Jason Merrill <jason@redhat.com> wrote:

> I want to explicitly pass -std=c++98 to the compiler used in building
> stage 1.  Does this seem like the right way to do that?

It certainly works, but I'm a bit concerned about its overriding the
earlier choices of STAGE1_CXXFLAGS, that use CXXFLAGS or STAGE1_CFLAGS
depending on whether or not C++ is being bootstrapped.  Now, since GCC
is in C++ nowadays, not bootstrapping C++ is not really possible, so it
seems to make sense to just drop it.  The top-level is shared with other
projects written in C++, but this change would only impact them if they
involved bootstrapping too, which AFAIK only GCC does.

The only serious problem with the patch is that it changes Makefile.in,
but not the corresponding part of Makefile.tpl from which it is
generated.  Ok with that change.

Now, if you'd also update the comments just before it, that still
suggest we build only C in stage1, that would be appreciated.

Thanks,

-- 
Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/   FSF Latin America board member
Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer

  reply	other threads:[~2015-05-20 22:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20 17:27 Jason Merrill
2015-05-20 22:16 ` Alexandre Oliva [this message]
2015-05-21 15:11   ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=oriobmq4q8.fsf@livre.home \
    --to=aoliva@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).