From: Alexandre Oliva <oliva@adacore.com>
To: Jason Merrill <jason@redhat.com>
Cc: gcc-patches@gcc.gnu.org, Nathan Sidwell <nathan@acm.org>
Subject: Re: [PATCH] call maybe_return_this in build_clone
Date: Wed, 22 Nov 2023 05:26:24 -0300 [thread overview]
Message-ID: <orjzqambwv.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <7164371d-a0b7-456d-8e01-0f04b6e99902@redhat.com> (Jason Merrill's message of "Mon, 20 Nov 2023 10:40:03 -0500")
On Nov 20, 2023, Jason Merrill <jason@redhat.com> wrote:
> So it only passed on that platform before because of the bug?
I'm not sure it passed (we've had patches for that testcase before), but
I didn't look closely enough into their history to tell. I suspected
the warning suppression machinery changed, or details on cloning did, or
something. It's been fragile historically. But yeah, recently, the
test for the warning was only passing because of the bug. But we were
also getting excess warnings, so it wasn't fully passing.
Thanks for the reviews!
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
More tolerance and less prejudice are key for inclusion and diversity
Excluding neuro-others for not behaving ""normal"" is *not* inclusive
next prev parent reply other threads:[~2023-11-22 8:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-19 7:38 Alexandre Oliva
2023-11-20 15:40 ` Jason Merrill
2023-11-22 8:26 ` Alexandre Oliva [this message]
2024-02-07 16:24 ` Torbjorn SVENSSON
2024-02-09 18:57 ` Jason Merrill
2024-02-09 21:14 ` Torbjorn SVENSSON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=orjzqambwv.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).