From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1762 invoked by alias); 4 Jun 2011 10:48:40 -0000 Received: (qmail 1753 invoked by uid 22791); 4 Jun 2011 10:48:39 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 04 Jun 2011 10:48:18 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p54AmIdk006428 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 4 Jun 2011 06:48:18 -0400 Received: from freie.oliva.athome.lsd.ic.unicamp.br (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p54Am82I029598 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sat, 4 Jun 2011 06:48:17 -0400 Received: from livre.localdomain (livre-to-gw.oliva.athome.lsd.ic.unicamp.br [172.31.160.19]) by freie.oliva.athome.lsd.ic.unicamp.br (8.14.4/8.14.4) with ESMTP id p54Am0qk018580 for ; Sat, 4 Jun 2011 07:48:00 -0300 Received: from livre.localdomain (aoliva@localhost.localdomain [127.0.0.1]) by livre.localdomain (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id p54AhSma005629; Sat, 4 Jun 2011 07:43:28 -0300 Received: (from aoliva@localhost) by livre.localdomain (8.14.3/8.14.3/Submit) id p54AhO0a005627; Sat, 4 Jun 2011 07:43:24 -0300 From: Alexandre Oliva To: gcc-patches@gcc.gnu.org Subject: Re: [PR debug/47624] improve value tracking in non-VTA locations References: Date: Sat, 04 Jun 2011 10:48:00 -0000 In-Reply-To: (Alexandre Oliva's message of "Tue, 15 Feb 2011 16:14:29 -0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00296.txt.bz2 On Feb 15, 2011, Alexandre Oliva wrote: > VTA only tracks locations of gimple regs, while addressable variables > still use the old var tracking strategy. This means addressable > variables, during var-tracking, got locations that were not based on > VALUEs, which failed immediately in the presence of auto-inc addresses. > The locations also tended to degrade in other ways, when a register > holding an address happened to be overwritten at a later point. > This patch arranges for us to track addresses of these variables as > VALUEs, and to emit new locations for them when a location whose value > was used to compute its address changes, fixing the problem. > The patch was regstrapped on x86_64-linux-gnu and i686-linux-gnu. Ok to > install? Ping? Retested on both platforms, unchanged except for fixing the typo s/deug/debug/ in the ChangeLog entry, that Jakub caught. http://gcc.gnu.org/ml/gcc-patches/2011-02/msg00981.html > for gcc/ChangeLog > from Alexandre Oliva > PR deug/47624 > * var-tracking.c (add_stores): Add FIXME note. > (compute_bb_dataflow): Use value-based locations in MO_VAL_SET. > (emit_notes_in_bb): Likewise. > (check_changed_vars_4): New. > (emit_noets_for_changes): Call it. -- Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist Red Hat Brazil Compiler Engineer