From: Alexandre Oliva <oliva@adacore.com>
To: Jonathan Wakely <jwakely.gcc@gmail.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] [libstdc++] [testsuite] require cmath for c++23 cmath tests
Date: Wed, 12 Jun 2024 19:43:50 -0300 [thread overview]
Message-ID: <orle39hjdl.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <CAH6eHdTvbGVN7Wnf-HZW-pjD=F2Z9_f3pM8aoSrZXb+G9pZUZg@mail.gmail.com> (Jonathan Wakely's message of "Wed, 12 Jun 2024 08:20:47 +0100")
On Jun 12, 2024, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
> On Wed, 12 Jun 2024, 02:17 Alexandre Oliva, <oliva@adacore.com> wrote:
>>
>> Some c++23 tests fail on targets that don't satisfy dg-require-cmath,
>> because referenced math functions don't get declared in std.
> Are they present on the target at all? Is not declaring them in std the
> underlying bug here?
Some are present on the target, but the <cmath> implementation doesn't
bring them into std because the detection for them in libc concludes the
feature is not available.
Should they be declared even if using them would cause link errors? Or
should libstdc++ offer additional fallback implementations?
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
More tolerance and less prejudice are key for inclusion and diversity
Excluding neuro-others for not behaving ""normal"" is *not* inclusive
next prev parent reply other threads:[~2024-06-12 22:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 1:16 Alexandre Oliva
2024-06-12 7:20 ` Jonathan Wakely
2024-06-12 22:43 ` Alexandre Oliva [this message]
2024-06-13 10:35 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=orle39hjdl.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely.gcc@gmail.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).