From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id CC5343858D20 for ; Sun, 28 Apr 2024 07:37:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC5343858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CC5343858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714289869; cv=none; b=b9lBBASKjAf0LjisflBmQsmz8hasuw16YWk7UhjG0XBBWw3+YL9jD2BEzDQHsX9cKu2+cDIAzl2+xZI3zNfuxyIBVecuqvBo2imaYR5TPA/mhvnksWjYa7zs5e7HsI4namv3kiyiALh5LnH02VhjbsWHPVyQgPXA0jV6Q3QEZQg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714289869; c=relaxed/simple; bh=a9tM5AMWKDPGsAWYUZ17p7RS0rZM/NQrmUjqf+M365E=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=hbErUiAERoGg2p1xhxJxNrO4JeVQEJ/r8c5dACVCz2iy/h51fWnRge4YbM5eGuBZqH1plk4lox8j3+mzWCPh7J2lFvDeEp64NL15PPpvSmy2ZdMkiha7fWHhrpxcUBWtalIcRBjAqjS1JDI+eiICXAx3qPiHcL06nINC+3YQAck= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-5dcc4076c13so2509004a12.0 for ; Sun, 28 Apr 2024 00:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1714289865; x=1714894665; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=LCCTsoHujrWSG5CnCjVOl3aePgQ1xDNNJBogVMuNXKU=; b=aDm+W5bYvL/pUyH2Jr+/RO+zX4kixzSFdawf9FAzcOpL3zQRr93dUH/VyJ7D9X5vuB aQb0qoWFqq1OI9Y0Xq4iyK5FgmsKDf6Bg2pKiUw1fWTkfZ8QjFxFfpLLAcjIqGf4jo6a vOpzB2h+UHyhAat9MOlchgY6HFY6dvxlO/oMAbRdc1Yw3nfyAa1qxU0vlHF1CSJRr5WC U0u//S66ILr3+OxJAtBNSjFeMuK5ksiuUPH6f1tw0teB+YDhioVD0JHEdfdmg5vNtoT0 a/dhAe95yCnHjDxi5TeHBbBcGMgyOasjzGly1CPUMBFCnK+cV92bv/sLumSeS4Ghk51Y jZbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714289865; x=1714894665; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LCCTsoHujrWSG5CnCjVOl3aePgQ1xDNNJBogVMuNXKU=; b=LAabSL1NuuTJocVrwfHMDIfYwfCxQEyFhhiA1vERmTJscpzh122omT1/I0hW2SF3Om Vb6FN0Gda3UTd1N2IGqa3ktv2INXxwNa69nZPzxIcvS9lGw5x4XB7THMpk542PnEJ8VV J2/rqIfkoWHl0j8sG/I3oPmXEcwevlVyZWp9aTxxvJFTtq+EGD6CBlZok3ENHf9PhJII Q80OB+x8pf7NwoP5EdWhWkntGGJQ4xyuFuYHcjg/yakTA3n+Ym5R27WxRM6Q2XShKKY8 k6DMdyNCM9oWjJ8sIKTmOijPIBjQ+njrXsfyyAJVDig8lO7a0YOdGSv2O+20KLI5Hx7F oSBQ== X-Forwarded-Encrypted: i=1; AJvYcCVesLeaN5JVy7XsetBW8xG/L68wWm6RkSkZcMG/FXVd+dkKWJiGjUOSFP5hCLwA1Hsxm+F4l0zkBIXKSkXM78VXh2lIppCwSg== X-Gm-Message-State: AOJu0YwoXT7Su6Tc4gxAkEkeRelzS85ZQLj4VCs5l2BJz897Fr93NrdW P6xvCCHB6mtVuVMWLw0ULLKpIpM1DTOUVvlrBYHSfXWDN4giiymTZkcZLIDGIA== X-Google-Smtp-Source: AGHT+IEmiq7YWixBkquy4N3j8U3l8jwdi3/1waut0n4xDyJnzrAa3VcCCps72Jx67HatlNkVjNzHqA== X-Received: by 2002:a17:902:680e:b0:1e2:7734:63dd with SMTP id h14-20020a170902680e00b001e2773463ddmr4752976plk.30.1714289864716; Sun, 28 Apr 2024 00:37:44 -0700 (PDT) Received: from free.home ([2804:7f1:218b:5e2:c43b:e0c4:71a:241b]) by smtp.gmail.com with ESMTPSA id c13-20020a170902b68d00b001e8a7ec6aabsm16939324pls.49.2024.04.28.00.37.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Apr 2024 00:37:44 -0700 (PDT) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 43S7bSEn278255 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sun, 28 Apr 2024 04:37:28 -0300 From: Alexandre Oliva To: Iain Sandoe Cc: "Kewen.Lin" , Rainer Orth , Mike Stump , David Edelsohn , Segher Boessenkool , Kewen Lin , Hans-Peter Nilsson , GCC Patches , Richard Biener Subject: Re: [PATCH v2] [testsuite] require sqrt_insn effective target where needed Organization: Free thinker, does not speak for AdaCore References: <6de1dd9d-de60-6a0c-7a25-67533957e62b@linux.ibm.com> Date: Sun, 28 Apr 2024 04:37:28 -0300 In-Reply-To: (Iain Sandoe's message of "Tue, 23 Apr 2024 10:14:04 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Apr 23, 2024, Iain Sandoe wrote: >>> --- a/gcc/testsuite/gcc.target/powerpc/pr46728-10.c >>> +++ b/gcc/testsuite/gcc.target/powerpc/pr46728-10.c >>> @@ -1,6 +1,7 @@ >>> /* { dg-do run } */ >>> /* { dg-skip-if "-mpowerpc-gpopt not supported" { powerpc*-*-darwin* } } */ >>> /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ >>> +/* { dg-require-effective-target sqrt_insn } */ >> >> This change looks sensible to me. >> >> Nit: With the proposed change, I'd expect that we can remove the line for powerpc*-*-darwin*. >> >> CC Iain to confirm. > Indeed, the check for sqrt_insn fails and so the test is unsupported without needing the separate > powerpc*-*-darwin* line, Thanks, here's the adjusted version I'm just about to push. [testsuite] require sqrt_insn effective target where needed Some tests fail on ppc and ppc64 when testing a compiler [with options for] for a CPU [emulator] that doesn't support the sqrt insn. The gcc.dg/cdce3.c is one in which the expected shrink-wrap optimization only takes place when the target CPU supports a sqrt insn. The gcc.target/powerpc/pr46728-1[0-4].c tests use -mpowerpc-gpopt and call sqrt(), which involves the sqrt insn that the target CPU under test may not support. Require a sqrt_insn effective target for all the affected tests. for gcc/testsuite/ChangeLog * gcc.dg/cdce3.c: Require sqrt_insn effective target. * gcc.target/powerpc/pr46728-10.c: Likewise. Drop darwin explicit skipping. * gcc.target/powerpc/pr46728-11.c: Likewise. Likewise. * gcc.target/powerpc/pr46728-13.c: Likewise. Likewise. * gcc.target/powerpc/pr46728-14.c: Likewise. Likewise. --- gcc/testsuite/gcc.dg/cdce3.c | 3 ++- gcc/testsuite/gcc.target/powerpc/pr46728-10.c | 2 +- gcc/testsuite/gcc.target/powerpc/pr46728-11.c | 2 +- gcc/testsuite/gcc.target/powerpc/pr46728-13.c | 2 +- gcc/testsuite/gcc.target/powerpc/pr46728-14.c | 2 +- 5 files changed, 6 insertions(+), 5 deletions(-) diff --git a/gcc/testsuite/gcc.dg/cdce3.c b/gcc/testsuite/gcc.dg/cdce3.c index 601ddf055fd71..f759a95972e8b 100644 --- a/gcc/testsuite/gcc.dg/cdce3.c +++ b/gcc/testsuite/gcc.dg/cdce3.c @@ -1,7 +1,8 @@ /* { dg-do compile } */ /* { dg-require-effective-target hard_float } */ +/* { dg-require-effective-target sqrt_insn } */ /* { dg-options "-O2 -fmath-errno -fdump-tree-cdce-details -fdump-tree-optimized" } */ -/* { dg-final { scan-tree-dump "cdce3.c:11: \[^\n\r]* function call is shrink-wrapped into error conditions\." "cdce" } } */ +/* { dg-final { scan-tree-dump "cdce3.c:12: \[^\n\r]* function call is shrink-wrapped into error conditions\." "cdce" } } */ /* { dg-final { scan-tree-dump "sqrtf \\(\[^\n\r]*\\); \\\[tail call\\\]" "optimized" } } */ /* { dg-skip-if "doesn't have a sqrtf insn" { mmix-*-* } } */ diff --git a/gcc/testsuite/gcc.target/powerpc/pr46728-10.c b/gcc/testsuite/gcc.target/powerpc/pr46728-10.c index 3be4728d333a4..c04a3101c113f 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr46728-10.c +++ b/gcc/testsuite/gcc.target/powerpc/pr46728-10.c @@ -1,6 +1,6 @@ /* { dg-do run } */ -/* { dg-skip-if "-mpowerpc-gpopt not supported" { powerpc*-*-darwin* } } */ /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ +/* { dg-require-effective-target sqrt_insn } */ #include diff --git a/gcc/testsuite/gcc.target/powerpc/pr46728-11.c b/gcc/testsuite/gcc.target/powerpc/pr46728-11.c index 43b6728a4b812..d0e3d60212194 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr46728-11.c +++ b/gcc/testsuite/gcc.target/powerpc/pr46728-11.c @@ -1,6 +1,6 @@ /* { dg-do run } */ -/* { dg-skip-if "-mpowerpc-gpopt not supported" { powerpc*-*-darwin* } } */ /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ +/* { dg-require-effective-target sqrt_insn } */ #include diff --git a/gcc/testsuite/gcc.target/powerpc/pr46728-13.c b/gcc/testsuite/gcc.target/powerpc/pr46728-13.c index b9fd63973b728..2b9df737a9b0d 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr46728-13.c +++ b/gcc/testsuite/gcc.target/powerpc/pr46728-13.c @@ -1,6 +1,6 @@ /* { dg-do run } */ -/* { dg-skip-if "-mpowerpc-gpopt not supported" { powerpc*-*-darwin* } } */ /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ +/* { dg-require-effective-target sqrt_insn } */ #include diff --git a/gcc/testsuite/gcc.target/powerpc/pr46728-14.c b/gcc/testsuite/gcc.target/powerpc/pr46728-14.c index 5affff13bdb6c..e6836f515e4f8 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr46728-14.c +++ b/gcc/testsuite/gcc.target/powerpc/pr46728-14.c @@ -1,6 +1,6 @@ /* { dg-do run } */ -/* { dg-skip-if "-mpowerpc-gpopt not supported" { powerpc*-*-darwin* } } */ /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ +/* { dg-require-effective-target sqrt_insn } */ #include -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive