From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id 0DE5C38515E3; Thu, 25 Mar 2021 11:03:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0DE5C38515E3 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oliva@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E1FBB117D83; Thu, 25 Mar 2021 07:03:07 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3GQmOBv-10y8; Thu, 25 Mar 2021 07:03:07 -0400 (EDT) Received: from free.home (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id A78F9117F4E; Thu, 25 Mar 2021 07:03:07 -0400 (EDT) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 12PB31is567429 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Mar 2021 08:03:02 -0300 From: Alexandre Oliva To: Jonathan Wakely Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: require et random_device for cons token test Organization: Free thinker, does not speak for AdaCore References: <20210324085907.GD3008@redhat.com> <20210324112718.GF3008@redhat.com> <20210324140140.GH3008@redhat.com> Errors-To: aoliva@lxoliva.fsfla.org Date: Thu, 25 Mar 2021 08:03:01 -0300 In-Reply-To: <20210324140140.GH3008@redhat.com> (Jonathan Wakely's message of "Wed, 24 Mar 2021 14:01:40 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Mar 2021 11:03:09 -0000 On Mar 24, 2021, Jonathan Wakely wrote: > diff --git a/libstdc++-v3/testsuite/util/testsuite_random.h b/libstdc++-v3/testsuite/util/testsuite_random.h > index 0b670bfb771..c8323078492 100644 > --- a/libstdc++-v3/testsuite/util/testsuite_random.h > +++ b/libstdc++-v3/testsuite/util/testsuite_random.h > @@ -197,6 +197,19 @@ namespace __gnu_test > } > #endif > + // Check whether TOKEN can construct a std::random_device successfully. > + inline bool > + random_device_available(const std::string& token) noexcept > + { > + try { > + std::random_device dev(token); > + return true; > + } catch (...) { > + std::printf("random_device(\"%s\") not available\n", token); Another nit: I'm seeing line noise (do people still use this term? :-) in libstdc++.log where unavailable random_device tokens should appear. I suspect the token has to be converted to a C string in the call above. -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar