From: Alexandre Oliva <oliva@adacore.com>
To: Jonathan Wakely <jwakely.gcc@gmail.com>
Cc: Jonathan Wakely <jwakely@redhat.com>,
"libstdc++" <libstdc++@gcc.gnu.org>,
gcc-patches@gcc.gnu.org, Corentin Gay <gay@adacore.com>
Subject: Re: Add dg-require-wchars to libstdc++ testsuite
Date: Fri, 15 Jan 2021 13:18:53 -0300 [thread overview]
Message-ID: <orlfcugolu.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <CAH6eHdRF64DBGsB-3bRa44mg2j5rxRO-EzqYs0TJNFNTrNmBiA@mail.gmail.com> (Jonathan Wakely's message of "Fri, 15 Jan 2021 10:09:46 +0000")
On Jan 15, 2021, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
> On Thu, 14 Jan 2021, 22:22 Alexandre Oliva, <oliva@adacore.com> wrote:
>> ... it is definitely the case that the target currently defines wchar_t,
>> and it even offers wchar.h and a lot of (maybe all?) wcs* functions.
>> This was likely not the case when the patch was first written.
>>
>> I'll double check whether any of the patch is still needed for current
>> versions.
With the tests I've run since yesterday, I've determined that:
- the wchar-related patches for the libstdc++ testsuite, that I had
proposed last year, are no longer needed
- your two patchlets did not bring about any regressions to test
results, not in mainline x86_64-linux-gnu native, not with the trivial
backports to the gcc-10 tree for x-arm-vxw7r2 that was the focus of my
immediate attention.
So, I withdraw my submissions of the testsuite patches, and I encourage
you to proceed with the two changes you proposed.
However, for avoidance of any doubt, I'll restate that I cannot vow for
whether they're enough to fix the issues we'd run into back when
wchar/wcs* were not supported in the target system, because now they
are, so the changes do not bring any visible improvements to our results
either.
Anyway, thanks for the feedback!
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Vim, Vi, Voltei pro Emacs -- GNUlius Caesar
next prev parent reply other threads:[~2021-01-15 16:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 21:12 Alexandre Oliva
2020-12-28 18:23 ` François Dumont
2021-01-13 17:29 ` Alexandre Oliva
2021-01-14 13:08 ` Jonathan Wakely
2020-12-28 18:27 ` François Dumont
2021-01-14 13:41 ` Jonathan Wakely
2021-01-14 13:47 ` Add dg-require-wchars to libstdc++ testsuite# Jonathan Wakely
2021-01-14 22:20 ` Add dg-require-wchars to libstdc++ testsuite Alexandre Oliva
2021-01-15 10:09 ` Jonathan Wakely
2021-01-15 16:18 ` Alexandre Oliva [this message]
2021-01-15 19:47 ` Jonathan Wakely
2021-10-09 7:31 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=orlfcugolu.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=gay@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely.gcc@gmail.com \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).