From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19975 invoked by alias); 15 Nov 2017 03:45:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19875 invoked by uid 89); 15 Nov 2017 03:45:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KB_WAM_FROM_NAME_SINGLEWORD,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=H*o:Group, america, America X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Nov 2017 03:45:23 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 41DA54E4C1; Wed, 15 Nov 2017 03:45:18 +0000 (UTC) Received: from freie.home (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 034DC8E7BA; Wed, 15 Nov 2017 03:45:17 +0000 (UTC) Received: from livre (livre.home [172.31.160.2]) by freie.home (8.15.2/8.15.2) with ESMTP id vAF3j8j4012163; Wed, 15 Nov 2017 01:45:08 -0200 From: Alexandre Oliva To: Richard Biener Cc: Jeff Law , Jason Merrill , GCC Patches Subject: Re: [SFN+LVU+IEPM v4 7/9] [LVU] Introduce location views References: <20171110023448.28164-7-aoliva@redhat.com> Date: Wed, 15 Nov 2017 03:59:00 -0000 In-Reply-To: (Richard Biener's message of "Mon, 13 Nov 2017 11:06:49 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017-11/txt/msg01147.txt.bz2 On Nov 13, 2017, Richard Biener wrote: > What does final.c need langhooks for? Thanks for catching this. At some point I had a check on whether there could be being stmt markers emitted by the language, but that's long gone, in part because of LTO; that's now computed dynamically, on a per-function basis, so the check was modified to match, but the include added back then lingered. Consider it gone (I'm dropping it in the SFN and SLI branches, so it won't be in the next version of the patchset) > I'd appreciate a DWARF person reviewing the dwarf bits, some new > static fns seem to lack their toplevel comment. Thanks for pointing this out. I've added the following comments: /* Return true iff we're to emit .loc directives for the assembler to generate line number sections. */ >> +output_asm_line_debug_info (void) /* Add a view list attribute to DIE. It must have a DW_AT_location attribute, because the view list complements the location list. */ >> +add_AT_view_list (dw_die_ref die, enum dwarf_attribute attr_kind) /* Return a pointer to the location list referenced by the attribute. If the named attribute is a view list, look up the corresponding DW_AT_location attribute and return its location list. */ >> AT_loc_list_ptr (dw_attr_node *a) /* Return the location attribute value associated with a view list attribute value. */ >> +view_list_to_loc_list_val_node (dw_val_node *val) > The middle-end pieces are ok. Thanks! -- Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer