From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id C0D3C3858408 for ; Mon, 20 Nov 2023 02:33:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C0D3C3858408 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C0D3C3858408 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::635 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700447601; cv=none; b=Od3/pG9+cX0g9UAUv8NZTr42WIfmZr8bi13RcqbRd25OMZPzdK4YheWYb6ESW1xIWjCO01KhlTjiXqdVDCvD+oc92mX1bRlF2+xu/Mx0opayjV/tImoboTaynz+7VdxVoahBKjOAfqnlWFgbdgO1D+oouRgZ9jlmVICqk4wG1Og= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700447601; c=relaxed/simple; bh=lzZE8C0uDiNzAKUuthfB2nJSkAMH6vNXQcxohV0Ag4U=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=aaF2HKpPOBGbuoImmGccO4hNjkFlZW2U+z/MWn6qrMST2N17td/N9xoQcITrsuNnRHutTp4m1lX6/yH76KryqsrMNDmnT20YWKekRxnUP5vArU3mIKsPVez9nq6pxLtz/qUVZ2H2xlE6hYCfaTGh20ucoPYJLA47RbMghifVU14= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1cf61eed213so2539255ad.2 for ; Sun, 19 Nov 2023 18:33:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1700447598; x=1701052398; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:date:organization:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=Fz/rdRSoOW4crOzDju5/DhS35j5tnHskX+GK9UB/FzA=; b=GUEGCyFT3xOA5opXAP8BwldSsgS0fx+7Zocz1RNE2FG2W5goWuqpOjCyXh0PYXOtS6 hmKz8b6dLAE97LWuytLxQFcbx/J71PPd1d2AeC9dzhmSjCECIXdj58J8f36+294Hn/f6 CmcPaLpbhj1lNiGSz+7PDkyAtELNZHnPPfS/bj+PYP/dT+mfBqJmoVJkNMXsknITfFXZ dWZPwz4SyrN4asgv3rloQpUyifhUE8reN4UArTqa197WHI0wj+XKmKq/5TluCsW9hMNE qktCvYin5SMsTqepowMbsayL0f1n3lwP9pA58AIIIYej4IKc0rENP9BOoupLkAWt3qxH Gv3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700447598; x=1701052398; h=mime-version:user-agent:message-id:date:organization:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Fz/rdRSoOW4crOzDju5/DhS35j5tnHskX+GK9UB/FzA=; b=PXsXRDLU+NeGuGs7QHRCth5Us/9TvV+NK+L6tqD0AeQ5undJqtXsWhvwYtl2n0Mx1+ a6uxJWN8G8ifdLml8/awxvgec/8MniAJYnPW7yIakhNGeIIV5sUsCHced9w33K0+9uNJ j9LdbByfnbwS4vCuiIzYOb+5Mcjueqp4R18SQNJ6Qxvz2yIDRU5aQI6w3Npsbp2b+CDs R7awLHd+Vn3pm2GQrtWOcI+KizYbZhpt/xbmsWZwaaAGdED1xkkzT/QVUFF1gGuLgm92 ncYv4wbqLHFPXlNynSfDVnqe3v2m/oNRtP3BT9ZcpVi+8mPChSLYcKwbYVuNQotYBEzc iBsg== X-Gm-Message-State: AOJu0YyK5vTXCT/ye4SFWsKDq8G8rtYbdqJQ1Q9mSy7GnKVy9rm2geF/ wstlg/JdzkO8lB4mSPMvNGggRI9Cy+EF51fz/LQ= X-Google-Smtp-Source: AGHT+IFPxjeG8QCZQXYPwB8esHA2xu1ATwZok1VbnSnSgAHXiCLvLaWhgrviQtL/gIbQu6FJo7mRgg== X-Received: by 2002:a17:902:da88:b0:1cc:3fc9:7d09 with SMTP id j8-20020a170902da8800b001cc3fc97d09mr8397869plx.15.1700447597563; Sun, 19 Nov 2023 18:33:17 -0800 (PST) Received: from free.home ([2804:7f1:2080:51b3:d545:cbee:40c0:c7a7]) by smtp.gmail.com with ESMTPSA id w1-20020a1709026f0100b001cc3fae06a6sm5080566plk.159.2023.11.19.18.33.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 18:33:17 -0800 (PST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 3AK2X3vv146593 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sun, 19 Nov 2023 23:33:04 -0300 From: Alexandre Oliva To: gcc-patches@gcc.gnu.org Cc: Nick Clifton , Richard Earnshaw , Ramana Radhakrishnan , Kyrylo Tkachov , Rainer Orth , Mike Stump Subject: [PATCH] testsuite: arm: fix arm_movt cut&pasto Organization: Free thinker, does not speak for AdaCore Date: Sun, 19 Nov 2023 23:33:03 -0300 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I got spurious fails of tests that required arm_thumb1_movt_ok on a target cpu that did not support movt. Looking into it, I found the arm_movt property to have been cut&pasted into various procs that checked for different properties. They shouldn't share the same test results cache entry, so I'm changing their prop names. Regstrapped on x86_64-linux-gnu, also tested on arm-eabi with default cpu on trunk, and with tms570 on gcc-13. Ok to install? for gcc/testsuite/ChangeLog * lib/target-supports.exp (check_effective_target_arm_thumb1_cbz_ok): Fix prop name cut&pasto. (check_effective_target_arm_arch_v6t2_hw_ok): Likewise. --- gcc/testsuite/lib/target-supports.exp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index 240a3815d38a7..e3519207d0e61 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -5610,7 +5610,7 @@ proc check_effective_target_arm_thumb1_movt_ok {} { proc check_effective_target_arm_thumb1_cbz_ok {} { if [check_effective_target_arm_thumb1_ok] { - return [check_no_compiler_messages arm_movt object { + return [check_no_compiler_messages arm_cbz object { int foo (void) { @@ -5627,7 +5627,7 @@ proc check_effective_target_arm_thumb1_cbz_ok {} { proc check_effective_target_arm_arch_v6t2_hw_ok {} { if [check_effective_target_arm_thumb1_ok] { - return [check_no_compiler_messages arm_movt object { + return [check_no_compiler_messages arm_v6t2_hw object { int main (void) { -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive