From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 31BC83858D20 for ; Sun, 28 Apr 2024 07:34:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 31BC83858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 31BC83858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714289653; cv=none; b=o4lPIS6+Fd7OCTKiyIH90hG4cxOU5oLcqoFkXq1BHpFiqiOkasXJdvDd2hcICt4mI1jSVnjBzpxT5fOhGLdIwqkWzr6fT5IwrIov3QGEfRYGSpR76HH2MKhPzlzp0dIp9RnRMM4yPxQYA7UPxpZSG1tfHDgtnKJHifK15Wm+Oyo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714289653; c=relaxed/simple; bh=TXyfCc5RpxiL4AbftEyjx7snPuPt5RClV1ALqzOM4/8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=iVuq8JE3K/Hg5DTiN/PepvRPVIJ/fatLMu4D/9kOlB0bbtZdT9vmLl8WlYWbB7drCVtVmgjvBSgcc2jL1fgSdl92SOsC1LlRbt9THIOEOR6RG+ZTABvFzcsPXIBH0suTejrLfECefBa5XkPxY8CAAXrpYJViEtF6Wrjtct9Gi2M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-6ed32341906so3346686b3a.1 for ; Sun, 28 Apr 2024 00:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1714289648; x=1714894448; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=KZZE3sdPF9nRsI3dy4965KUjpc508xsXwFMWNd9ulR4=; b=aHEI0PeumXxhXEVMjxuBQXyfJJX4N+K/VwX87R4cGOoGvpN2Euk5mgT799gqzQXZVG EmCE7/AS5b0BDdmO27LpBIYk2YLJX1pOtDjVbcAFaeuFfS88zoyLTNwGt0Zo9agByilb 1bl+axesPn6swWg9Vhm3hFfAxcPsTA0jZftKSK97ULoh+eyGBla+wOv0V8O1PWVCUpT+ EYfTM9nkNVJQyzS6YVRKfRSTYb0cgwOVhq3zs0C7/ZhHHikRpgU0tYarsQEldnkNzmlp tqhhsSEFg8FT2ueiDK+iOeuCYgnlmXW4CRJVI8dDuCHa76HUTPBylv20TGQMb3VJKq/t cH6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714289648; x=1714894448; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KZZE3sdPF9nRsI3dy4965KUjpc508xsXwFMWNd9ulR4=; b=TvMwTZ3DPLBBPrwZPaA3cCWn3LebWNCZGDHOsxRL06WSESSAgpSARwap0jZzQ0W5F0 11UkRVqaaGsLbZIB1cLwxBlfdzHFX5qhHFeMSVMxCEdanqsWQB3RjbVMQigXOZoVf2C4 wTy3e8lTqPfBkInJFcaLZFJGtdk+2ELeloz2HFHh9b6Sokzn2jvzEL9yW2gBseYFDr3v S6tOJSWiHodV0dbWFxo6fw5+wSD4xtTbDb3ltowjg6f2zmI9wuV1poQjP/HLxJ468R16 1eCk922ActoOYEoUokLgJ1tPaWKsQ4ydk+ZS765v3TaCA3xC2WQuuz8ZRBjHyJsA4N6A DUVw== X-Forwarded-Encrypted: i=1; AJvYcCWv8v91MM4+i3eNIDvnCZYzXmdEeu88VKuh/ZfX78rsAaoOz1GWMFSfj2HVQ9DJcKo8QhMH0+xMLKXtbhJpwIHnDPtgEnRdEQ== X-Gm-Message-State: AOJu0YzSzXQIEKMDRoWR5he17mW8nTyyCgJ0znbrwCUqHBop5C7U0WZB TjM5TKPQq4pes3BhWmC/jfEWngkZQ5o6Xa9QNQ1wNyijpptznEqzvyPQF24h7Q== X-Google-Smtp-Source: AGHT+IH3ANnTNCryueerUpfropGKUwLh8KFGjMJmwGbq9m+tQUSKi1w51dznK4g7hUhcdSg7AQmdYA== X-Received: by 2002:a05:6a20:1016:b0:1a9:3ac0:f1f1 with SMTP id gs22-20020a056a20101600b001a93ac0f1f1mr6462850pzc.34.1714289645818; Sun, 28 Apr 2024 00:34:05 -0700 (PDT) Received: from free.home ([2804:7f1:218b:5e2:c43b:e0c4:71a:241b]) by smtp.gmail.com with ESMTPSA id y8-20020aa78048000000b006f2e10b00d6sm11159338pfm.41.2024.04.28.00.34.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Apr 2024 00:34:05 -0700 (PDT) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 43S7XlRO278118 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sun, 28 Apr 2024 04:33:48 -0300 From: Alexandre Oliva To: "Kewen.Lin" Cc: Rainer Orth , Mike Stump , David Edelsohn , Segher Boessenkool , Kewen Lin , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] ppc: testsuite: vec-mul requires vsx runtime Organization: Free thinker, does not speak for AdaCore References: Date: Sun, 28 Apr 2024 04:33:47 -0300 In-Reply-To: (Kewen Lin's message of "Tue, 23 Apr 2024 14:51:13 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_QUOTING autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Apr 23, 2024, "Kewen.Lin" wrote: >> -/* { dg-do run } */ >> +/* { dg-do compile { target { ! vsx_hw } } } */ >> +/* { dg-do run { target vsx_hw } } */ >> /* { dg-require-effective-target powerpc_vsx_ok } */ > Nit: It's useless to check powerpc_vsx_ok for vsx_hw, so powerpc_vsx_ok check > can be moved to be with ! vsx_hw. > OK with this nit tweaked, thanks! Thanks, here's what I'm pushing momentarily... ppc: testsuite: vec-mul requires vsx runtime vec-mul is an execution test, but it only requires a powerpc_vsx_ok effective target, which is enough only for compile tests. In order to check for runtime and execution environment support, we need to require vsx_hw. Make that a condition for execution, but still perform a compile test if the condition is not satisfied. for gcc/testsuite/ChangeLog * gcc.target/powerpc/vec-mul.c: Run on target vsx_hw, just compile otherwise. --- gcc/testsuite/gcc.target/powerpc/vec-mul.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/gcc.target/powerpc/vec-mul.c b/gcc/testsuite/gcc.target/powerpc/vec-mul.c index bfcaf80719d1d..aa0ef7aa45acc 100644 --- a/gcc/testsuite/gcc.target/powerpc/vec-mul.c +++ b/gcc/testsuite/gcc.target/powerpc/vec-mul.c @@ -1,5 +1,5 @@ -/* { dg-do run } */ -/* { dg-require-effective-target powerpc_vsx_ok } */ +/* { dg-do compile { target { { ! vsx_hw } && powerpc_vsx_ok } } } */ +/* { dg-do run { target vsx_hw } } */ /* { dg-options "-mvsx -O3" } */ /* Test that the vec_mul builtin works as expected. */ -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive