From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id DE3F53858D1E for ; Wed, 29 Nov 2023 09:40:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DE3F53858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DE3F53858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::434 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701250815; cv=none; b=OmqcP5RD76PqBM4OVvo1IYrOa7rUh79CM/dGGuVzO8oxn6oS+YXkHfFNvwsyJlGdikT+1gkOKJxfvH14TN+0OZ/IklNgzNxB9RXN2hhMVED2drs/0kGUBZULuB5Bb9Eqz1MQxn887yyeWWAuZrTjO0oXVstUPceZ/3Bkp82wLKI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701250815; c=relaxed/simple; bh=AfgJCJvjYhknv1SHVDX7/VbPCBOJeNGWVoURZ6DdHoE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=aZnxXe/u6VdPjlbqMDORWwzYbRk+vrj6VZAginoNK9owTlsYL1iPyNeDAGvm2RNVm7kXxU2Cj9mzqHfeKt9ph1R8eHb5sUzXTjZBHqU6DBlLdbdk3CVp4p9Y4pjizhjG5jHN1Q8eEW4rDMEdfWVL7ODi6OR+4Gc/LbpEULSo8+w= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-6cdd28aa7f8so354171b3a.3 for ; Wed, 29 Nov 2023 01:40:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1701250813; x=1701855613; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:organization:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=zH3H7olLGrZ2een7L1VuaVkcES2bsKAhjTcQ1UgEgzU=; b=i+3yGcmoscvWNm3DV80aAvmcA9f//l2p62hMN/z9pgavp7W0REyN+vw3ZShVRmoKPQ nQutjMnfKujVymbFgHBjOePh8fFTCTaTsFUWdIetH8h+Ada4gH4JqSUhiY0QyZ3+l5ws qpwsyFS5W9oTnv8YfVttR8lUsefgngRcT16b6QjrD4ZN2oAI6PLfoijC7OFf92aJnBah E+DLea62eHBcO5WE6Xph/FC1gRsU6gnu68BRKj+2/i+0WMLi6PwQC+AfY1qFJfqthoZZ 9DJEkouUiG/ftc1ExEY0AdtF3fkhXt1QKth7U3NHIpWT73Wul7azU3jpCFpk0vXUT8Gr /VwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701250813; x=1701855613; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:organization:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zH3H7olLGrZ2een7L1VuaVkcES2bsKAhjTcQ1UgEgzU=; b=QpoHYlDliNP2uAEtyoNqZBN2yOVxVddppKPk/SQiaaRuHF9G+wVkw9K0/ggNL2xsNO s95T9Mkwuf/im3odNrsekQXUlO2Dow6MWipiMIDlqaOsMEhvhg3KFMU/vvE7cbaZ3/8K JTZ5StUEx5CuTZ3IDhRsK5RfJ9WzhIDHIgP53Oxjd6K514UJebQ1f9yu/aRkQeJQge8J 6f9mAelJboM6LHU5uHjholWy/J4cJEuPiMZ+EqAGHfELYF5oJbvw7mn/5KortX344UoP D5u23AJfSBUbOIQIHKVxzhvfgJT7MpagoG6s/yvvZRYzPU2clF1uJCpAYh2/oME+jsSV 8OYA== X-Gm-Message-State: AOJu0Yzh3GYTsHX5lALEtmmteUSvynetfC+7Yy2Q4i3m/kUb8yGopMpC fHaEvAJhxNpX6j0YAnu+Y9AXcw== X-Google-Smtp-Source: AGHT+IEZ0TkJZyvJz0TsbylFEiCktOzT/nFHmeQbcPmveOX/CE3GwwcADRy0bL03B8KI+tG8+OJbJg== X-Received: by 2002:a05:6a21:99a5:b0:18a:d5a8:93e3 with SMTP id ve37-20020a056a2199a500b0018ad5a893e3mr18128862pzb.61.1701250812746; Wed, 29 Nov 2023 01:40:12 -0800 (PST) Received: from free.home ([2804:7f1:2080:8316:5de:a3fa:396c:13d9]) by smtp.gmail.com with ESMTPSA id f8-20020a170902684800b001cf7bd9ade5sm12032472pln.3.2023.11.29.01.40.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 01:40:12 -0800 (PST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 3AT9dvfk024838 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 29 Nov 2023 06:39:58 -0300 From: Alexandre Oliva To: Jason Merrill Cc: gcc-patches@gcc.gnu.org, David Malcolm , Rainer Orth , Mike Stump , Nathan Sidwell , "H.J. Lu" Subject: Re: [PATCH #2/4] c++: mark short-enums as packed Organization: Free thinker, does not speak for AdaCore References: <78e7499c-2278-44ff-8455-503e3690e3fd@redhat.com> <9d922575-6f5a-4458-b3dc-a25dce128e24@redhat.com> <9f88b17b-4202-454c-abbd-6d9c999ceee8@redhat.com> Date: Wed, 29 Nov 2023 06:39:57 -0300 In-Reply-To: <9f88b17b-4202-454c-abbd-6d9c999ceee8@redhat.com> (Jason Merrill's message of "Wed, 22 Nov 2023 13:26:58 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, Jason, On Nov 22, 2023, Jason Merrill wrote: > On 11/22/23 13:12, Jason Merrill wrote: >> I'm coming to the conclusion that your C++ patch is fine but we >> should remove the TYPE_PACKED warning from=20 >> check_address_or_pointer_of_packed_member.=C2=A0 And maybe add >> -Wcast-align=3Dstrict to -Wextra. > Since I seem to have opinions, I'm preparing a patch for this. Thanks for that patch. It makes sense to me, but I suppose that, if it goes in, I should revert the already-installed #1/4 in this series https://gcc.gnu.org/pipermail/gcc-patches/2023-November/637244.html rather than install #4/4 that Mike approved. https://gcc.gnu.org/pipermail/gcc-patches/2023-November/637336.html I wasn't sure whether your earlier conclusion (quoted above) was meant as an 'Ok' for the C++ patch. Please confirm if so. TIA, --=20 Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive