From: Alexandre Oliva <oliva@adacore.com>
To: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: require et random_device for cons token test
Date: Wed, 24 Mar 2021 03:53:23 -0300 [thread overview]
Message-ID: <oro8f9avq4.fsf@lxoliva.fsfla.org> (raw)
On target systems that don't support any random_device, not even the
default one, other random_device constructor tests are disabled by
dg-require-effective-target random_device. The token.cc also
exercises the default constructor, in a way that doesn't expect an
exception to be raised, but it's not guarded by the same requirement.
Other potentially-raising ctors in token.cc expect exceptions and
handle them, but the ("default")-constructed one does not, so the
program terminates and the test fails without exercising the other
constructor variants.
This patch arranges to disable the test altogether when the
random_device feature is not available. A reasonable alternative
would be to install a std::runtime_error handler around the test01
body, so that we exercise at least the exception raising, but then
test03 would have to be relaxed, since without even "default", it
likely wouldn't meet the tested requirement there.
Regstrapped on x86_64-linux-gnu and cross-tested for x86_64-vx7r2 along
with other patches, mostly for the testsuite. Ok to install?
for libstdc++-v3/ChangeLog
* testsuite/26_numerics/random/random_device/cons/token.cc:
Require effective target feature random_device.
---
.../26_numerics/random/random_device/cons/token.cc | 1 +
1 file changed, 1 insertion(+)
diff --git a/libstdc++-v3/testsuite/26_numerics/random/random_device/cons/token.cc b/libstdc++-v3/testsuite/26_numerics/random/random_device/cons/token.cc
index defb8d58c586a..105ae0ba87743 100644
--- a/libstdc++-v3/testsuite/26_numerics/random/random_device/cons/token.cc
+++ b/libstdc++-v3/testsuite/26_numerics/random/random_device/cons/token.cc
@@ -1,4 +1,5 @@
// { dg-do run { target c++11 } }
+// { dg-require-effective-target random_device }
// { dg-require-cstdint "" }
//
// 2008-11-24 Edward M. Smith-Rowland <3dw4rd@verizon.net>
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Vim, Vi, Voltei pro Emacs -- GNUlius Caesar
next reply other threads:[~2021-03-24 6:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 6:53 Alexandre Oliva [this message]
2021-03-24 8:59 ` Jonathan Wakely
2021-03-24 10:33 ` Alexandre Oliva
2021-03-24 11:27 ` Jonathan Wakely
2021-03-24 14:01 ` Jonathan Wakely
2021-03-25 10:17 ` Alexandre Oliva
2021-03-25 11:57 ` Jonathan Wakely
2021-03-26 19:17 ` Jonathan Wakely
2021-03-25 11:03 ` Alexandre Oliva
2021-03-25 11:39 ` Jonathan Wakely
2021-03-25 11:00 ` Alexandre Oliva
2021-03-25 11:38 ` Jonathan Wakely
2021-11-09 15:02 ` Jonathan Wakely
2021-03-24 10:55 ` Jonathan Wakely
2021-03-24 13:22 ` Koning, Paul
2021-03-24 13:38 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=oro8f9avq4.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).