From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id DB63C3858D3C for ; Thu, 7 Dec 2023 21:40:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DB63C3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DB63C3858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::231 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701985211; cv=none; b=dWkp+CFZMn/NKPQ+xBxTFjtc93yuP+3m6lfAW8gGHDe/w6imqWetqbTFFGNYxZR3DCi9j4Xv7acuRMXJ/9yisE0HWt370Wu2zIzh/TlXh8bvirHS2mkc/xDl+Dc33Srob1DlJUkHwV1Kd8n5spL+IeypQTXq2J5mYvsSilT5a9E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701985211; c=relaxed/simple; bh=8iT3yhBZcyhrnKhIYydIMJkBGXIT9cSnBcaBtoL2yYk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=AM+ouDwEOmEmsrOytCO5hToJiA5Sjvfv7prtygsU9iiNxoO/kJeq1D5yAKtjHo0eC/10bM7trsKGm/HQn1Pcwp5QVTvebEXhiYEQv+uyFkkGbeo7cYkMwIWcgJbB3SiasIJh55FjfAngAVsl+DqPsO2vLqnFgoQq1kCEITHZw8Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x231.google.com with SMTP id 5614622812f47-3b9e2a014e8so590676b6e.2 for ; Thu, 07 Dec 2023 13:40:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1701985208; x=1702590008; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=wkTZhPtXuKDIa8ddayuiCgnUwOsY92rdQu7wfZVs8cA=; b=a4XtrZGZFQwBYCDu6hjP7mkRLtxbwmKjH2bGtCUqs+fD4ZmbOF71tbwFe4SRdw8Cj7 J+cl/LGwRtSGBhu6e6ZCYbGKImmV6rRzDuCW6XDntTVuGc1P5byGvMh3+nBAxNeWlIeb ZJ2qqI5ka+92x92NpKvsp0sFbZtObApoE4xfC3dDLkmCf9CqpZuqXL57dT5upP94fdYo AUtMizPSu3tYT6KDkHt1XTjq1iSGavvWQqKdjfLZaQ6brAZ8cC3KxvV0G1RDTxsvXxuz 8dGHbfp6CNM7St8+yAJwuOJ+YRPkg9HeIGablLvVLwko9hPhZliPvwVnXukhNOObRRVO qmIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701985208; x=1702590008; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wkTZhPtXuKDIa8ddayuiCgnUwOsY92rdQu7wfZVs8cA=; b=rmayXCi/Cd68v52c4+yL3ZMa6ZojKaO0P3xzq2IO3jiQpw1FwtlL+jsFvAw3j97SDQ mcZKvMU4DiYqcrDp8wqOBU0+O7gqgszU9+EAtl33pRyS52uMD2bjRk3xI/YmbvQhFlww Q938m8+EcJd+yvtvsszH1W6BgmNCfelPtnndzzvw2dnZotULxCEPMMJuRu1SUEqOr26h IL6AfHH4YAt1u/MsrnkKkiPoHsDpocvkDh/B03t1v7JctL4UacCdYWKNEfgh4x3VLXTC AmqGARAx/5XzPQtl7h+KTVOHmd8F6c36+cSBKD7zFWfD0Y1RYXkfW23XPLwokIayqMgy yd6g== X-Gm-Message-State: AOJu0YyXrXKCRzQJT9wbsRKq5Osoa/T7KlPAqydzhDRvgLvXi4RLKZYK ybA4NZ0m1b5w+C7jLVEr1ThCMKtvakeJdYMY/Y1f7A== X-Google-Smtp-Source: AGHT+IF5lQmOD/a4Zs6CZXo+XqrrW9STwBb02P4FWBR3DIqhDIW5p81OMFLr0MrV+B+7PBho9soK2w== X-Received: by 2002:a05:6359:4593:b0:170:8cdc:83ef with SMTP id no19-20020a056359459300b001708cdc83efmr1077305rwb.20.1701985208499; Thu, 07 Dec 2023 13:40:08 -0800 (PST) Received: from free.home ([2804:14c:4d1:44a5:f4d9:b7a4:4fb8:376f]) by smtp.gmail.com with ESMTPSA id kr5-20020a056a004b4500b006ce83da3076sm248391pfb.170.2023.12.07.13.40.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 13:40:07 -0800 (PST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 3B7LdwVV284906 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 7 Dec 2023 18:39:59 -0300 From: Alexandre Oliva To: Jan Hubicka Cc: Richard Biener , gcc-patches@gcc.gnu.org, Jeremy Bennett , Craig Blackmore , Graham Markall , Martin Jambor , Jim Wilson , Jeff Law , Jakub Jelinek Subject: Re: [PATCH v5] Introduce strub: machine-independent stack scrubbing Organization: Free thinker, does not speak for AdaCore References: Date: Thu, 07 Dec 2023 18:39:58 -0300 In-Reply-To: (Jan Hubicka's message of "Wed, 6 Dec 2023 11:22:13 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Dec 6, 2023, Jan Hubicka wrote: > There is also access attribute which speaks directly about individual > arugments, perhaps you want to drop this one too? Ah, I've looked a little into it, and now I have a vague recollection of why I don't mess with them: they only apply to arguments of pointer or reference type, and those are not (supposed to be) affected by the changes, not by indirection (which is what would make some "fn spec" notes impossible to convey), not by insertion of synthetic parameters. Those are placed at the end in part to avoid messing with parameter-index attributes. So attribute access can safely be left alone. Thanks for raising the issue. Maybe there should be at least a comment there, and perhaps some asserts to check that pointer and reference types don't make to indirect_parms. -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive