From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 99530388216F for ; Sun, 19 Nov 2023 07:30:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 99530388216F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 99530388216F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::630 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700379019; cv=none; b=HA4m9+BjhGNo92MIQudfq137Y/jpTP2ZbqS3xo+R3JjfoGm+w/7JyZOcxnJkoQFdKY73Ms41q56o0OJmgseagp/THMziYJ5/VnSvdc9yP1HgCNLtZ30GRUv4o5iAO7h01pak6qNWGG2f6PmQgACra7SgsqU6vFymlKEk2WiNJ8A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700379019; c=relaxed/simple; bh=DeErV9PUyVBDirnfrDaQt6wpOEmJXPPR+uH4iRxYLJk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=I0/y3m1NQyTXng9mqGDGiahUN3IZZ5+OvcYDqI64EiPBl7OT4G0H3RiBiMjmSAq/D5yRuHlRBytKDvmTT5mVsi3iyirUWICF5OKmPk14wJCWvAmWR8tApT8ElxpLy+QO9PDuLNWpSeBiB3FguGIzGUUnbwaErlmRkYtlH7OWJt8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1ce618b7919so11977835ad.0 for ; Sat, 18 Nov 2023 23:30:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1700379016; x=1700983816; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:date:organization:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=sKpgDf7eYJEAkfm/2dnUWt2UDx9efe5VRetNNADVuUE=; b=bqPvdnMiiYNl1jzo6Qzmax+3HNH4ShjobTYp8xpEYyEnrncL9eWoB1SCy7aed577st WksWejsQpd4PXAcKgQWBjSM2W5X3QN+zXjztHnHHuNujWQntJ3SQWW51jsjeJXUIPjRE JyoDj87C3olsY3L1NsgzkYkiMv8AjKTPTgPIoaVpciZNLkDSjRXC6w/0XynDp10zqSH3 rVOT/UGDjbkrlPLUzAJiRtvq1XDZknRve6UZDvkV83KjuMt6Q2vLfDCIOQgE9L9Cf5di jpwirHqk8SWgDYg3DVLoDrgu8x+yM50M9aAYa0hmR03EBGKOIA770KAODc59Ggs++6Cg wENw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700379016; x=1700983816; h=mime-version:user-agent:message-id:date:organization:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sKpgDf7eYJEAkfm/2dnUWt2UDx9efe5VRetNNADVuUE=; b=Uzgr5FUMsipss9JA6UPyJ1zEZ70NnB31KchkCXW8CkP/lKNfE8+GMfGNVakZBZQpXq sRvvOfOJYy3JcaKknzHhkXLNIZslv+ese+am79o9NQjr7ruYGZfVHrVQhTw4HbHDKICS 7UzlfPogSMghTwf+/MDEvcMMYFmC85sRVxduFzf6HRzYZ9g593/s00+EKKpMUix0Dl6y 6nVzKbvOT4dE/x45xUirCVsCCC399Nsy1OG2sV2nB568QK4tpPNeGLe5RVJ/Y2MPfuq3 zzYHNlyZ5dgiPPR0wTJMTPjtGSherNfi1qelOddrln8XIH0UhOWi9exbPJcH6/u6AGsA Y76g== X-Gm-Message-State: AOJu0YwWtIl1rqoxUlzw6CUzbS/EvnyUqtVQHtQ2eEBiKJ9IOmvCBRwz ctB+tBxBaAu+4Ugnn0yTqjXaCluxFJc0olduNJLo1Q== X-Google-Smtp-Source: AGHT+IENE0n3Dvyy0fojS2HPocN70b2ovxRO3ZUuJ533ohql99KODmMTaDg3zHhXjWUIBJ3O8nGQiQ== X-Received: by 2002:a17:902:f68c:b0:1cc:3004:750c with SMTP id l12-20020a170902f68c00b001cc3004750cmr14973324plg.20.1700379016554; Sat, 18 Nov 2023 23:30:16 -0800 (PST) Received: from free.home ([2804:7f1:2080:51b3:d545:cbee:40c0:c7a7]) by smtp.gmail.com with ESMTPSA id y4-20020a17090322c400b001bbb7af4963sm3918256plg.68.2023.11.18.23.30.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 23:30:16 -0800 (PST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 3AJ7U0oe121697 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sun, 19 Nov 2023 04:30:00 -0300 From: Alexandre Oliva To: gcc-patches@gcc.gnu.org Cc: Richard Biener , Rainer Orth , Mike Stump Subject: [PATCH] testsuite: scev: expect fail on ilp32 Organization: Free thinker, does not speak for AdaCore Date: Sun, 19 Nov 2023 04:30:00 -0300 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I've recently patched scev-3.c and scev-5.c because it only passed by accident on ia32. It also fails on some (but not all) arm-eabi variants. It seems hard to characterize the conditions in which the optimization is supposed to pass, but expecting them to fail on ilp32 targets, though probably a little excessive and possibly noisy, is not quite as alarming as getting a fail in test reports, so I propose changing the xfail marker from ia32 to ilp32. I'm also proposing to add a similar marker to scev-4.c. Though it doesn't appear to be failing for me, I've got reports that suggest it still does for others, and it certainly did for us as well. Regstrapped on x86_64-linux-gnu, also tested on arm-eabi with default cpu on trunk, and with tms570 on gcc-13. Ok to install? for gcc/testsuite/ChangeLog * gcc.dg/tree-ssa/scev-3.c: xfail on all ilp32 targets, though some of these do pass. * gcc.dg/tree-ssa/scev-4.c: Likewise. * gcc.dg/tree-ssa/scev-5.c: Likewise. --- gcc/testsuite/gcc.dg/tree-ssa/scev-3.c | 3 ++- gcc/testsuite/gcc.dg/tree-ssa/scev-4.c | 3 ++- gcc/testsuite/gcc.dg/tree-ssa/scev-5.c | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c index ac8c8d4519e30..beea9aed9fe95 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c @@ -40,4 +40,5 @@ __BB(6): } -/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ia32 } } } */ +/* Not all 32-bit systems fail this, but several do. */ +/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c index 57cb021340218..a97f75f81f654 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c @@ -45,4 +45,5 @@ __BB(6): } -/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" } } */ +/* Not all 32-bit systems fail this, but several do. */ +/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c index c911a9298866f..08f4260403c40 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c @@ -40,4 +40,5 @@ __BB(6): } -/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ia32 } } } */ +/* Not all 32-bit systems fail this, but several do. */ +/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */ -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive