From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTPS id 52D1B385843D; Wed, 23 Feb 2022 22:39:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 52D1B385843D Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4902F116345; Wed, 23 Feb 2022 17:39:47 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id UsAGdHPf8bhY; Wed, 23 Feb 2022 17:39:47 -0500 (EST) Received: from free.home (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id B9F27116192; Wed, 23 Feb 2022 17:39:46 -0500 (EST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 21NMdbHn714530 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Feb 2022 19:39:37 -0300 From: Alexandre Oliva To: Richard Biener Cc: Jeff Law , Vladimir Makarov , zsojka@seznam.cz, GCC Patches , wilson@gcc.gnu.org Subject: Re: [PR103302] skip multi-word pre-move clobber during lra Organization: Free thinker, does not speak for AdaCore References: <74d2af86-c1c4-0842-b319-09e76b3bf633@gmail.com> <4bf89538-8c3c-59a7-378b-d02982e6a5ea@gmail.com> <03226f85-0334-1840-94f9-6c618175f974@gmail.com> Errors-To: aoliva@lxoliva.fsfla.org Date: Wed, 23 Feb 2022 19:39:35 -0300 In-Reply-To: (Richard Biener's message of "Mon, 21 Feb 2022 08:13:32 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Feb 2022 22:39:49 -0000 On Feb 21, 2022, Richard Biener wrote: >> Ok to revert commit r12-5852-g50e8b0c9bca6cdc57804f860ec5311b641753fbb > OK. Please re-open the bug as appropriate. Thanks. I've reopened it. Here's what I'm installing. I'm not reverting the testcase, since it stopped failing even before the patch was put in. Revert commit r12-5852-g50e8b0c9bca6cdc57804f860ec5311b641753fbb The patch for PR103302 caused PR104121, and extended the live ranges of LRA reloads. for gcc/ChangeLog PR target/104121 PR target/103302 * expr.cc (emit_move_multi_word): Restore clobbers during LRA. --- gcc/expr.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/expr.cc b/gcc/expr.cc index 35e40299753bb..5f7142b975ada 100644 --- a/gcc/expr.cc +++ b/gcc/expr.cc @@ -3929,7 +3929,7 @@ emit_move_multi_word (machine_mode mode, rtx x, rtx y) hard regs shouldn't appear here except as return values. We never want to emit such a clobber after reload. */ if (x != y - && ! (lra_in_progress || reload_in_progress || reload_completed) + && ! (reload_in_progress || reload_completed) && need_clobber != 0) emit_clobber (x); -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Disinformation flourishes because many people care deeply about injustice but very few check the facts. Ask me about