From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTPS id CC74A3858D35; Thu, 9 Dec 2021 04:08:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CC74A3858D35 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9D0FB11719A; Wed, 8 Dec 2021 23:08:54 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HwhxeaP80KBH; Wed, 8 Dec 2021 23:08:54 -0500 (EST) Received: from free.home (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id 3685E117084; Wed, 8 Dec 2021 23:08:54 -0500 (EST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 1B948jtY942269 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 9 Dec 2021 01:08:46 -0300 From: Alexandre Oliva To: Jeff Law Cc: gcc-patches@gcc.gnu.org, zsojka@seznam.cz, wilson@gcc.gnu.org Subject: Re: [PR103302] skip multi-word pre-move clobber during lra Organization: Free thinker, does not speak for AdaCore References: <74d2af86-c1c4-0842-b319-09e76b3bf633@gmail.com> Errors-To: aoliva@lxoliva.fsfla.org Date: Thu, 09 Dec 2021 01:08:45 -0300 In-Reply-To: <74d2af86-c1c4-0842-b319-09e76b3bf633@gmail.com> (Jeff Law's message of "Wed, 8 Dec 2021 16:12:05 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Dec 2021 04:08:56 -0000 On Dec 8, 2021, Jeff Law wrote: >> expr.c (emit_move_multi_word): Skip clobber during lra. > OK. I found a similar pattern of issuing clobbers for multi-word moves, but not when reload_in_progress, in expr.c:emit_move_complex_parts. I don't have a testcase, but I'm tempted to propose '!lra_in_progress &&' for it as well. Can you think of any reason not to? I also see lots of uses of reload_in_progress in machine-dependent code, and I suspect many cases involving enabling patterns or checking for legitimate addresses might benefit from the addition of lra_in_progress, but that's too many occurrences to try to make sense of :-( -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Disinformation flourishes because many people care deeply about injustice but very few check the facts. Ask me about