From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id 9859D386F811; Wed, 13 Jan 2021 17:29:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9859D386F811 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oliva@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 76FF3561A0; Wed, 13 Jan 2021 12:29:25 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HPem6y8CpqPe; Wed, 13 Jan 2021 12:29:25 -0500 (EST) Received: from free.home (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id 3EEA95619B; Wed, 13 Jan 2021 12:29:25 -0500 (EST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 10DHTIdj203242 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Jan 2021 14:29:18 -0300 From: Alexandre Oliva To: =?utf-8?Q?Fran=C3=A7ois?= Dumont , Jonathan Wakely Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org, Corentin Gay Subject: Re: Add dg-require-wchars to libstdc++ testsuite Organization: Free thinker, does not speak for AdaCore References: References: <6ebcdfda-bb74-793e-753d-983d45c48651@gmail.com> Errors-To: aoliva@lxoliva.fsfla.org Date: Wed, 13 Jan 2021 14:29:17 -0300 In-Reply-To: (Alexandre Oliva's message of "Tue, 22 Dec 2020 18:12:25 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2021 17:29:27 -0000 On Dec 28, 2020, Fran=C3=A7ois Dumont wrote: > On 22/12/20 10:12 pm, Alexandre Oliva wrote: >> Some tests uses structures from the libstdc++ that are present only if >> the target has a wchar.h header. However, those tests do not check >> that the target supports those constructs before executing the tests. > Looks like those tests should be in some sub-folder containing > 'wchar_t' to be considered as UNSUP. > Maybe Jonathan will prefer them to be moved even if your approach > seems more convenient to me. I'd be glad to make such changes, but I'd appreciate stronger guidance as to the preferences and the way to go before doing so. Jonathan, would you please share your wisdom WRT this patch and the other wchar_t-related libstdc++ testsuite one? https://gcc.gnu.org/pipermail/gcc-patches/2020-December/562435.html https://gcc.gnu.org/pipermail/gcc-patches/2020-December/562438.html >> The function dg-require-wchars checks that "_GLIBCXX_USE_WCHAR_T" is >> defined by the configure of the libstdc++. If it is not the case, the >> test is not executed. > This check_v3_target_wchars looks like a good candidate to leverage > on: v3_check_preprocessor_condition. Nice!, thanks for the tip, I was not aware of this proc. --=20 Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar