On Nov  5, 2007, Mark Mitchell <mark@codesourcery.com> wrote:

>   /* Comparison function for a splay tree in which the keys are strings.
>      K1 and K2 have the dynamic type "const char *".  Returns <0, 0,
>      or >0 to indicate whether K1 is less than, equal to, or greater
>      than K2, respectively.  */

> probably, we do.  In the body of the function, you could write:

>   /* We use strcmp, rather than just comparing pointers, so that the
>      sort order will not depend on the host system.  */

> If you leave the assertion in, you definitely should comment:

>   /* The strings are always those from IDENTIFIER_NODEs, and, therefore,
>      we should never have two copies of the same string.  */

> The patch is OK with those changes.

Thanks, here's what I'm checking in: