From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78621 invoked by alias); 17 Aug 2015 02:57:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 78611 invoked by uid 89); 17 Aug 2015 02:57:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_05,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 17 Aug 2015 02:57:08 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id E255C98C04; Mon, 17 Aug 2015 02:57:06 +0000 (UTC) Received: from freie.home (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7H2v4SJ021579 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 16 Aug 2015 22:57:05 -0400 Received: from livre.home (livre.home [172.31.160.2]) by freie.home (8.14.8/8.14.8) with ESMTP id t7H2uRV1018293; Sun, 16 Aug 2015 23:56:27 -0300 From: Alexandre Oliva To: Andreas Schwab , Kyrylo Tkachov Cc: Patrick Marlier , Jeff Law , James Greenhalgh , "H.J. Lu" , Segher Boessenkool , Richard Biener , GCC Patches , Christophe Lyon , David Edelsohn , Eric Botcazou Subject: Re: [PR64164] drop copyrename, integrate into expand References: <20150723203112.GB27818@gate.crashing.org> <20150810082355.GA31149@arm.com> <55C8BFC3.3030603@redhat.com> Date: Mon, 17 Aug 2015 05:05:00 -0000 In-Reply-To: (Andreas Schwab's message of "Sun, 16 Aug 2015 12:07:50 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2015-08/txt/msg00874.txt.bz2 On Aug 16, 2015, Andreas Schwab wrote: > Alexandre Oliva writes: >> On Aug 15, 2015, Andreas Schwab wrote: >> >>> FAIL: gcc.target/aarch64/target_attr_crypto_ice_1.c (internal compiler error) >> >>> In file included from >>> /opt/gcc/gcc-20150815/gcc/testsuite/gcc.target/aarch64/target_attr_crypto_ice_1.c:4:0: >> >> Are you sure this is a regression introduced by my patch? > Yes, it reintroduces the ICE. Ugh. I see this testcase was introduced very recently, so presumably it wasn't present in the tree that James Greenhalgh tested and confirmed there were no regressions. The hack in aarch64-builtins.c looks risky IMHO. Changing the mode of a decl after RTL is assigned to it (or to its SSA partitions) seems fishy. The assert is doing just what it was supposed to do. The only surprise to me is that it didn't catch this unexpected and unsupported change before. Presumably if we just dropped the assert in expand_expr_real_1, this case would work just fine, although the unsignedp bit would be meaningless and thus confusing, since the subreg isn't about a promotion, but about reflecting the mode change that was made from under us. May I suggest that you guys find (or introduce) other means to change the layout and mode of the decl *before* RTL is assigned to the params? I think this would save us a ton of trouble down the road. Just think how much trouble you'd get if the different modes had different calling conventions, alignment requirements, valid register assignments, or anything that might make coalescing their SSA names with those of other variables invalid. -- Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer